Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intoroduced MediaGallerySynchronizationMetadata module #29761

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Intoroduced MediaGallerySynchronizationMetadata module #29761

merged 3 commits into from
Sep 2, 2020

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Aug 26, 2020

Description (*)

Intoroduced MediaGallerySynchronizationMetadata module eliminating dependency of MediaGallerySynchronization on MediaGalleryMetadataApi module

Approval Request: https://jira.corp.magento.com/browse/MC-37071

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/29
https://github.com/magento/partners-magento2ee/pull/313

Fixed Issues (if relevant)

https://jira.corp.magento.com/browse/MC-36993

Manual testing scenarios (*)

  1. Upgrade Magento 2.4.0 + Adobe Stock Integration 2.0.0 to Magento PR branch + Adobe Stock Integration 2.1.0
  2. Verify uploading images with metadata to the new media gallery
  3. Verify uploading images with metadata outside of media gallery

Git based upgrade scenario

git clone git@github.com:magento/magento2.git
cd magento2
git checkout 2.4.0
git clone git@github.com:magento/adobe-stock-integration.git ext/magento/stock-integration
cd ext/magento/stock-integration/
git checkout 2.0.0-master
cd ../../..
composer install
composer config minimum-stability dev
composer config repositories.ext path "./ext/*/*/*"
composer require magento/adobe-stock-integration
bin/magento setup:install
git checkout composer.json
git checkout composer.lock
composer install
git remote add sivaschenko git@github.com:sivaschenko/magento2.git
git fetch sivaschenko
git checkout media-gallery-synchronization-metadata
cd ext/magento/stock-integration/
git checkout 2.1.0-master
cd ../../..
git clone git@github.com:magento/adobe-ims.git ext/magento/adobe-ims
composer install
composer config minimum-stability dev
composer config repositories.ext path "./ext/*/*/*"
rm vendor/magento/module-adobe-ims*
composer require magento/adobe-stock-integration
bin/magento module:enable --all
bin/magento setup:upgrade

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8082 has been created to process this Pull Request

@sivaschenko
Copy link
Member Author

@magento run all tests

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Works by the described Git based upgrade scenario

Created a manual testing scenario on cucumber - https://studio.cucumber.io/projects/131313/test-plan/folders/1569351/scenarios/5137627

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 27, 2020
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento run Functional Tests CE,Functional Tests EE

@magento-engcom-team magento-engcom-team merged commit b579ccf into magento:2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGallerySynchronization Component: MediaGallerySynchronizationApi Component: MediaGallerySynchronizationMetadata Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants