Adds some more colors to the output of certain setup cli commands

[hostep]

Description (*)

While trying to figure out the sort order in which certain database migration scripts ran while executing bin/magento setup:upgrade, I found the output a bit hard to read.
So I've added a different color to the output of certain steps.

Before:

After:

This also influences some other bin/magento setup:xxx commands but it doesn't seem to degrade them in my opinion (but I haven't tested all of them).

Fixed Issues (if relevant)

None that I could find

Manual testing scenarios (*)

1. Execute the bin/magento setup:upgrade command and look if the colors used in the output make sense
2. Execute all other console commands that use the ConsoleLoggerInterface class and see if the colors used in the output make sense

Questions or comments

If you want different colors or if there are better idea's, let me know!
I've just re-used the "metadata" color which was already being used.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Adds some more colors to the output of certain setup cli commands #29335: Adds some more colors to the output of certain setup cli commands

[m2-assistant]

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

@magento run Static Tests

[hostep]

@magento run Static Tests

[hostep]

@magento run all tests

[hostep]

Before I put more effort in this, can I know if this improvement will be blocked by the failing Semantic Version Checker? Or should an architect first review the introduction of a new method to the interface and give his/her approval?

[VladimirZaets]

@magento create issue

[gabrieldagama]

The risk was set tolow due to: the suggested changes shouldn't affect other areas.

[engcom-Golf]

Hi @hostep, thank you for your contribution, I will take care of the required changes on the PR.

[engcom-Golf]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[hostep]

Can we have any sort of progress update here? Thanks! 🙂

[korostii]

@engcom-Golf @VladimirZaets @sidolov Respectfully, is someone looking through the older and low priority PRs nowadays, at all? How is it possible that they can be stuck for half a year with no progress from Magento end, at all?
Thanks in advance.

[hostep]

@korostii, it's not really a high prio issue to get this merged, but some kind of update would indeed be appreciated :)

Leaving PR's lying around, giving no updates is very discouraging to contributors. I've recently saw a discussion in the chat of MMUK21 where two very well known and experienced Magento contributors complained about the same thing and said it had no use anymore to send in PR's to Magento as they aren't getting processed in a timely manner. This is very sad to read, and I really hope the Magento maintainers will change this one day, preferably sooner than later. Adhering to priorities in PR's doesn't make a lot of sense because it means low prio PR's will never get processed. I complained about this before in #28927 (comment) BTW but nothing seems to happen 😞

[hostep]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Charlie]

As per this comment, moving it to Ready for Testing again.

[engcom-Bravo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Bravo]

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

Execute below commands:

bin/magento setup:upgrade
bin/magento setup:db-data:upgrade
bin/magento setup:install --base-url=http://local.magento2.com

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[hostep]

Thanks! But your screenshots under Before & After got uploaded in the wrong order I think, some of those need to be moved from Before to After and some from After to Before.

But happy to see it works as expected.

[engcom-Charlie]

@magento run Functional Tests EE,Functional Tests B2B, WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Echo]

Moving it to Pending Approval as the internal JIRA is yet to be approved for Semantic Version Checker failure

[engcom-Echo]

@magento run all tests

[engcom-Echo]

We have received approval for internal JIRA ticket.
Hence moving it to Extended Testing

[engcom-Echo]

@magento run Functional Tests EE ,Functional Tests B2B ,WebAPI Tests

[engcom-Echo]

@magento run Functional Tests B2B

[engcom-Echo]

Functional Tests B2B failures contain one(LYNX-180: Customer cancels an order from order history page.) common failure on last two run which is not related to PR changes.
Run1

Run2