createCustomer validation requirements #28888
+963
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\CustomerGraphQl\Model\Resolver; | ||
|
|
||
| use Magento\CustomerGraphQl\Model\Customer\ExtractCustomerData; | ||
| use Magento\CustomerGraphQl\Model\Customer\GetCustomer; | ||
| use Magento\CustomerGraphQl\Model\Customer\UpdateCustomerAccount; | ||
| use Magento\Framework\GraphQl\Config\Element\Field; | ||
| use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException; | ||
| use Magento\Framework\GraphQl\Query\ResolverInterface; | ||
| use Magento\Framework\GraphQl\Schema\Type\ResolveInfo; | ||
| use Magento\GraphQl\Model\Query\ContextInterface; | ||
|
|
||
| /** | ||
| * Customer email update, used for GraphQL request processing | ||
| */ | ||
| class UpdateCustomerEmail implements ResolverInterface | ||
| { | ||
| /** | ||
| * @var GetCustomer | ||
| */ | ||
| private $getCustomer; | ||
| /** | ||
| * @var UpdateCustomerAccount | ||
| */ | ||
| private $updateCustomerAccount; | ||
| /** | ||
| * @var ExtractCustomerData | ||
| */ | ||
| private $extractCustomerData; | ||
|
|
||
| /** | ||
| * @param GetCustomer $getCustomer | ||
| * @param UpdateCustomerAccount $updateCustomerAccount | ||
| * @param ExtractCustomerData $extractCustomerData | ||
| */ | ||
| public function __construct( | ||
| GetCustomer $getCustomer, | ||
| UpdateCustomerAccount $updateCustomerAccount, | ||
| ExtractCustomerData $extractCustomerData | ||
| ) { | ||
| $this->getCustomer = $getCustomer; | ||
| $this->updateCustomerAccount = $updateCustomerAccount; | ||
| $this->extractCustomerData = $extractCustomerData; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
|
There was a problem hiding this comment. you can add a proper description here |
||
| */ | ||
| public function resolve( | ||
| Field $field, | ||
| $context, | ||
| ResolveInfo $info, | ||
| array $value = null, | ||
| array $args = null | ||
| ) { | ||
| /** @var ContextInterface $context */ | ||
| if (false === $context->getExtensionAttributes()->getIsCustomer()) { | ||
| throw new GraphQlAuthorizationException(__('The current customer isn\'t authorized.')); | ||
| } | ||
|
|
||
| $customer = $this->getCustomer->execute($context); | ||
| $this->updateCustomerAccount->execute( | ||
| $customer, | ||
| ['email' => $args['email'], 'password' => $args['password']], | ||
|
There was a problem hiding this comment. unsafe array index, could cause an exception: |
||
| $context->getExtensionAttributes()->getStore() | ||
| ); | ||
|
|
||
| $data = $this->extractCustomerData->execute($customer); | ||
|
|
||
| return ['customer' => $data]; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\GraphQl\Customer; | ||
|
|
||
| use Exception; | ||
| use Magento\Customer\Api\CustomerRepositoryInterface; | ||
| use Magento\CustomerGraphQl\Model\Customer\UpdateCustomerAccount; | ||
| use Magento\Framework\Exception\AuthenticationException; | ||
| use Magento\Integration\Api\CustomerTokenServiceInterface; | ||
| use Magento\Store\Api\StoreRepositoryInterface; | ||
| use Magento\TestFramework\Helper\Bootstrap; | ||
| use Magento\TestFramework\TestCase\GraphQlAbstract; | ||
|
|
||
| /** | ||
| * Test for update customer's email | ||
| */ | ||
| class UpdateCustomerEmailTest extends GraphQlAbstract | ||
| { | ||
| /** | ||
| * @var CustomerTokenServiceInterface | ||
| */ | ||
| private $customerTokenService; | ||
|
|
||
| /** | ||
| * @var CustomerRepositoryInterface | ||
| */ | ||
| private $customerRepository; | ||
| /** | ||
| * @var UpdateCustomerAccount | ||
| */ | ||
| private $updateCustomerAccount; | ||
| /** | ||
| * @var StoreRepositoryInterface | ||
| */ | ||
| private $storeRepository; | ||
|
|
||
| /** | ||
| * Setting up tests | ||
| */ | ||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
|
|
||
| $this->customerTokenService = Bootstrap::getObjectManager()->get(CustomerTokenServiceInterface::class); | ||
| $this->customerRepository = Bootstrap::getObjectManager()->get(CustomerRepositoryInterface::class); | ||
| $this->updateCustomerAccount = Bootstrap::getObjectManager()->get(UpdateCustomerAccount::class); | ||
| $this->storeRepository = Bootstrap::getObjectManager()->get(StoreRepositoryInterface::class); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Customer/_files/customer.php | ||
| */ | ||
| public function testUpdateCustomerEmail(): void | ||
| { | ||
| $currentEmail = 'customer@example.com'; | ||
| $currentPassword = 'password'; | ||
|
|
||
| $newEmail = 'newcustomer@example.com'; | ||
|
|
||
| $query = <<<QUERY | ||
| mutation { | ||
| updateCustomerEmail( | ||
| email: "{$newEmail}" | ||
| password: "{$currentPassword}" | ||
| ) { | ||
| customer { | ||
| } | ||
| } | ||
| } | ||
| QUERY; | ||
|
|
||
| $response = $this->graphQlMutation( | ||
| $query, | ||
| [], | ||
| '', | ||
| $this->getCustomerAuthHeaders($currentEmail, $currentPassword) | ||
| ); | ||
|
|
||
| $this->assertEquals($newEmail, $response['updateCustomerEmail']['customer']['email']); | ||
|
|
||
| /* $this->updateCustomerAccount->execute( | ||
| $this->customerRepository->get($newEmail), | ||
| ['email' => $currentEmail, 'password' => $currentPassword], | ||
| $this->storeRepository->getById(1) | ||
| );*/ | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Customer/_files/customer.php | ||
| */ | ||
| public function testUpdateCustomerEmailIfPasswordIsWrong(): void | ||
| { | ||
| $this->expectException(Exception::class); | ||
| $this->expectExceptionMessage('Invalid login or password.'); | ||
|
|
||
| $currentEmail = 'customer@example.com'; | ||
| $currentPassword = 'password'; | ||
|
|
||
| $newEmail = 'newcustomer@example.com'; | ||
| $wrongPassword = 'wrongpassword'; | ||
|
|
||
| $query = <<<QUERY | ||
| mutation { | ||
| updateCustomerEmail( | ||
| email: "{$newEmail}" | ||
| password: "{$wrongPassword}" | ||
| ) { | ||
| customer { | ||
| } | ||
| } | ||
| } | ||
| QUERY; | ||
|
|
||
| $this->graphQlMutation( | ||
| $query, | ||
| [], | ||
| '', | ||
| $this->getCustomerAuthHeaders($currentEmail, $currentPassword) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Customer/_files/two_customers.php | ||
| */ | ||
| public function testUpdateEmailIfEmailAlreadyExists() | ||
| { | ||
| $this->expectException(Exception::class); | ||
| $this->expectExceptionMessage( | ||
| 'A customer with the same email address already exists in an associated website.' | ||
| ); | ||
|
|
||
| $currentEmail = 'customer@example.com'; | ||
| $currentPassword = 'password'; | ||
| $existedEmail = 'customer_two@example.com'; | ||
|
|
||
| $query = <<<QUERY | ||
| mutation { | ||
| updateCustomerEmail( | ||
| email: "{$existedEmail}" | ||
| password: "{$currentPassword}" | ||
| ) { | ||
| customer { | ||
| firstname | ||
| } | ||
| } | ||
| } | ||
| QUERY; | ||
| $this->graphQlMutation($query, [], '', $this->getCustomerAuthHeaders($currentEmail, $currentPassword)); | ||
| } | ||
|
|
||
| /** | ||
| * Get customer authorization headers | ||
| * | ||
| * @param string $email | ||
| * @param string $password | ||
| * @return array | ||
| * @throws AuthenticationException | ||
| */ | ||
| private function getCustomerAuthHeaders(string $email, string $password): array | ||
| { | ||
| $customerToken = $this->customerTokenService->createCustomerAccessToken($email, $password); | ||
| return ['Authorization' => 'Bearer ' . $customerToken]; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.