REVERT for public PR:22917

[VladimirZaets]

Description (*)

This PR reverts #22917 as it caused regression. More details in test report #28380 (comment)

Purpose for revert
During internal regression testing for future 2.4.0 release Core team found two regression bugs

1. [MC-34245] Adding a Product with Customizable Option to Wish List results in a fatal error
2. [MC-34322] Adding a Product with Customizable Option to a "Gift Registry" results in a fatal error when loading shared Gift Registry page

Root cause analysis defined that changes from #22917 brought these regression bugs.

After multiple discussion and several attempts to fix consequences was decided to revert this PR #22917

As soon as PR will be reverted related Issue #22856 will be reopened, confirmed again. The internal Jira ticket will be reopened/created for 2.4.x as well.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @VladimirZaets. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Alfa]

✔️ QA Passed

Case 1

[MC-34245] Adding a Product with Customizable Option to Wish List results in a fatal error

Preconditions:

• Magento 2.4-develop CE;
• A Simple Product with Customizable option is created:
  (for example, Option Title = Test, Option Type = Text, Field, Max Characters = 100);
• A Customer account is created;

Manual testing scenario:

1. Go to Storefront as the created Customer;
2. Go to the created Product page;
3. Enter some valid text into the Test input field ;
4. Click the “Add to Wish List” button ;

Before: ✖️ Error: Maximum function nesting level of "250"...

After: ✔️ The created product was added to Wish List

Case 2

[MC-34322] Adding a Product with Customizable Option to a "Gift Registry" results in a fatal error when loading shared Gift Registry page

Preconditions:

• Magento 2.4-develop EE;
• A Customer account is created;
• A Gift Registry is created;
• A Simple Product with Customizable option is created
  (for example, Option Title = Test, Option Type = Text, Field, Max Characters = 100)
• Add the created Product to the Gift Registry;

Manual testing scenario:

1. Go to Storefront as the created Customer;
2. Go to the created Gift Registry (My Account -> Gift Registry);
3. Click the “Share” link;
4. Fill all required fields with valid data;
5. Click on the “Share Gift Registry” button;
6. Open the message sent to the email, used to share Gift Registry;
7. Click the “Registry Location” link;

Before: ✖️ Error: Maximum function nesting level of "250"...

After: ✔️ “Gift Registry Items” grid contain the created Product

[magento-engcom-team]

Hi @sdzhepa, thank you for the review.
ENGCOM-7595 has been created to process this Pull Request
✳️ @sdzhepa, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ihor-sviziev]

Hi @VladimirZaets @sdzhepa,

1. Could you next time write some meaningful description? Motivation of this PR isn't clear at all.
   I just added short description myself based on my guess
2. Could you cover these changes with MFTF test in order to prevent re-introducing this issues again in future?
   /CC @naydav

[sdzhepa]

Hi @ihor-sviziev

Sorry, its my bad. I will add additional information to the description today.
But in general, you are right - this fix leads to the new bugs. These bugs were found by Core team during regression. After several discussions and review was decided to revert this PR

[lenaorobei]

Delivered to 2.4.0-develop.

[m2-assistant]

Hi @VladimirZaets, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.