Add product with customizable option to wishlist

[engcom-Charlie]

Description (*)

Fixed issue; covered by mftf

Related Pull Requests

Fixed Issues (if relevant)

1. Closes Adding products to wishlist with custom options #28103: Adding products to wishlist with custom options

Manual testing scenarios (*)

1. Create Simple Product with Customizable option
2. Create Customer account
3. Go to storefront as the created Customer
4. Go to the created Product page
5. Select customizable option
6. Click the “Add to Wish List” button

ER:
The created product should be added to Wish List
Wish List page should appear

AR:
Blank page
[2020-05-18 12:34:47] report.CRITICAL: Error: Maximum function nesting level of '256' reached, aborting! in /space/www/html/engcom/lib/internal/Magento/Framework/Model/AbstractModel.php:456

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered only manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s). <test-build(s)> is a comma-separated list of build names. Allowed build names are Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests.

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[eduard13]

Hi @engcom-Charlie thank you for the fix to the issue that I reported. Could you please check the below comments?

[engcom-Charlie]

@magento run all tests

[eduard13]

Looks good 👍

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7574 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create a Simple Product with Customizable option (Dropdown fo ex.);
2. Create Customer Account;
3. Go to Storefront as the created Customer;
4. Go to the created Product page;
5. Select customizable option;
6. Click the “Add to Wish List” button;

Before: ✖️ Error: Maximum function nesting level of '250'

After: ✔️ The product with customizable option was successfully added to Wish list

Also was tested with :

• field
• area
• file
• radio buttons
• checkbox
• multiple select

and everything works as expected.

Pull Request state was updated. Re-review required.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7574 has been created to process this Pull Request

[engcom-Alfa]

The validity of this decision is being discussed

Pull Request state was updated. Re-review required.

[engcom-Charlie]

On the internal decision, it was decided to revert PR #22917 which cause an issue. So I close this PR.

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.