Skip to content

#27500 Prepare DownloadableImportExport module Tests for PHPUnit 8 #27825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2020
Merged

#27500 Prepare DownloadableImportExport module Tests for PHPUnit 8 #27825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5743c7
#27500 Prepare DownloadableImportExport module Tests for PHPUnit 8
lbajsarowicz Apr 12, 2020
a327ad9
#27500 Fix static checks
lbajsarowicz Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/DownloadableImportExport/Test/Unit/Helper/DataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

namespace Magento\DownloadableImportExport\Test\Unit\Helper;

use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
use Magento\DownloadableImportExport\Helper\Data as HelperData;
use Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
use PHPUnit\Framework\TestCase;

class DataTest extends TestCase
Expand All @@ -23,7 +23,7 @@ class DataTest extends TestCase
/**
* Setup environment for test
*/
protected function setUp()
protected function setUp(): void
{
$objectManagerHelper = new ObjectManagerHelper($this);
$this->helper = $objectManagerHelper->getObject(HelperData::class);
Expand Down
98 changes: 56 additions & 42 deletions ...Magento/DownloadableImportExport/Test/Unit/Model/Import/Product/Type/DownloadableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,57 @@
<?php
<?php declare(strict_types=1);
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\DownloadableImportExport\Test\Unit\Model\Import\Product\Type;

use Magento\CatalogImportExport\Model\Import\Product;
use Magento\CatalogImportExport\Model\Import\Uploader;
use Magento\Downloadable\Model\Url\DomainValidator;
use Magento\DownloadableImportExport\Helper\Data;
use Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable;
use Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection;
use Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\CollectionFactory;
use Magento\Framework\App\ResourceConnection;
use Magento\Framework\DB\Adapter\Pdo\Mysql;
use Magento\Framework\DB\Select;
use Magento\Framework\EntityManager\MetadataPool;
use Magento\Framework\Exception\LocalizedException;
use Magento\Framework\Filesystem\Directory\Write;
use Magento\Framework\Phrase;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManager;
use Magento\ImportExport\Test\Unit\Model\Import\AbstractImportTestCase;
use PHPUnit\Framework\MockObject\MockObject;

/**
* Class DownloadableTest for downloadable products import
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class DownloadableTest extends \Magento\ImportExport\Test\Unit\Model\Import\AbstractImportTestCase
class DownloadableTest extends AbstractImportTestCase
{
/** @var ObjectManager|\Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable */
/** @var ObjectManager|Downloadable */
protected $downloadableModelMock;

/** @var \Magento\Framework\DB\Adapter\Pdo\Mysql|\PHPUnit_Framework_MockObject_MockObject */
/** @var Mysql|MockObject */
protected $connectionMock;

/** @var \Magento\Framework\DB\Select|\PHPUnit_Framework_MockObject_MockObject */
/** @var Select|MockObject */
protected $select;

/**
* @var \PHPUnit_Framework_MockObject_MockObject
* @var MockObject
*/
protected $attrSetColFacMock;

/**
* @var \Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection|\PHPUnit_Framework_MockObject_MockObject
* @var Collection|MockObject
*/
protected $attrSetColMock;

/**
* @var \PHPUnit_Framework_MockObject_MockObject
* @var MockObject
*/
protected $prodAttrColFacMock;

Expand All @@ -46,53 +61,52 @@ class DownloadableTest extends \Magento\ImportExport\Test\Unit\Model\Import\Abst
private $domainValidator;

/**
* @var \Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection|\PHPUnit_Framework_MockObject_MockObject
* @var \Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection|MockObject
*/
protected $prodAttrColMock;

/** @var \Magento\Framework\App\ResourceConnection|\PHPUnit_Framework_MockObject_MockObject */
/** @var ResourceConnection|MockObject */
protected $resourceMock;

/** @var \Magento\CatalogImportExport\Model\Import\Product|\PHPUnit_Framework_MockObject_MockObject */
/** @var \Magento\CatalogImportExport\Model\Import\Product|MockObject */
protected $entityModelMock;

/** @var array|mixed */
protected $paramsArray;

/** @var \Magento\CatalogImportExport\Model\Import\Uploader|\PHPUnit_Framework_MockObject_MockObject */
/** @var Uploader|MockObject */
protected $uploaderMock;

/** @var \Magento\Framework\Filesystem\Directory\Write|\PHPUnit_Framework_MockObject_MockObject */
/** @var Write|MockObject */
protected $directoryWriteMock;

/**
* @var |\PHPUnit_Framework_MockObject_MockObject
* @var MockObject
*/
protected $uploaderHelper;

/**
* @var |\PHPUnit_Framework_MockObject_MockObject
* @var MockObject
*/
protected $downloadableHelper;

/**
* Set up
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
protected function setUp()
protected function setUp(): void
{
parent::setUp();

//connection and sql query results
$this->connectionMock = $this->createPartialMock(
\Magento\Framework\DB\Adapter\Pdo\Mysql::class,
Mysql::class,
['select', 'fetchAll', 'fetchPairs', 'joinLeft', 'insertOnDuplicate', 'delete', 'quoteInto', 'fetchAssoc']
);
$this->select = $this->createMock(\Magento\Framework\DB\Select::class);
$this->select = $this->createMock(Select::class);
$this->select->expects($this->any())->method('from')->will($this->returnSelf());
$this->select->expects($this->any())->method('where')->will($this->returnSelf());
$this->select->expects($this->any())->method('joinLeft')->will($this->returnSelf());
$adapter = $this->createMock(\Magento\Framework\DB\Adapter\Pdo\Mysql::class);
$adapter = $this->createMock(Mysql::class);
$adapter->expects($this->any())->method('quoteInto')->will($this->returnValue('query'));
$this->select->expects($this->any())->method('getAdapter')->willReturn($adapter);
$this->connectionMock->expects($this->any())->method('select')->will($this->returnValue($this->select));
Expand All @@ -104,11 +118,11 @@ protected function setUp()
//constructor arguments:
// 1. $attrSetColFac
$this->attrSetColFacMock = $this->createPartialMock(
\Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\CollectionFactory::class,
CollectionFactory::class,
['create']
);
$this->attrSetColMock = $this->createPartialMock(
\Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection::class,
Collection::class,
['setEntityTypeFilter']
);
$this->attrSetColMock
Expand All @@ -129,7 +143,7 @@ protected function setUp()

// 3. $resource
$this->resourceMock = $this->createPartialMock(
\Magento\Framework\App\ResourceConnection::class,
ResourceConnection::class,
['getConnection', 'getTableName']
);
$this->resourceMock->expects($this->any())->method('getConnection')->will(
Expand All @@ -140,7 +154,7 @@ protected function setUp()
);

// 4. $params
$this->entityModelMock = $this->createPartialMock(\Magento\CatalogImportExport\Model\Import\Product::class, [
$this->entityModelMock = $this->createPartialMock(Product::class, [
'addMessageTemplate',
'getEntityTypeId',
'getBehavior',
Expand All @@ -160,12 +174,12 @@ protected function setUp()
];

$this->uploaderMock = $this->createPartialMock(
\Magento\CatalogImportExport\Model\Import\Uploader::class,
Uploader::class,
['move', 'setTmpDir', 'setDestDir']
);

// 6. $filesystem
$this->directoryWriteMock = $this->createMock(\Magento\Framework\Filesystem\Directory\Write::class);
$this->directoryWriteMock = $this->createMock(Write::class);

// 7. $fileHelper
$this->uploaderHelper = $this->createPartialMock(
Expand All @@ -174,7 +188,7 @@ protected function setUp()
);
$this->uploaderHelper->expects($this->any())->method('getUploader')->willReturn($this->uploaderMock);
$this->downloadableHelper = $this->createPartialMock(
\Magento\DownloadableImportExport\Helper\Data::class,
Data::class,
['prepareDataForSave', 'fillExistOptions']
);
$this->downloadableHelper->expects($this->any())->method('prepareDataForSave')->willReturn([]);
Expand Down Expand Up @@ -213,7 +227,7 @@ public function testSaveDataAppend($newSku, $bunch, $allowImport, $fetchResult)
));

$downloadableModelMock = $this->objectManagerHelper->getObject(
\Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable::class,
Downloadable::class,
[
'attrSetColFac' => $this->attrSetColFacMock,
'prodAttrColFac' => $this->prodAttrColFacMock,
Expand Down Expand Up @@ -528,7 +542,7 @@ public function testIsRowValid(array $rowData, $rowNum, $isNewProduct, $isDomain
->willReturn($isDomainValid);

$this->downloadableModelMock = $this->objectManagerHelper->getObject(
\Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable::class,
Downloadable::class,
[
'attrSetColFac' => $this->attrSetColFacMock,
'prodAttrColFac' => $this->prodAttrColFacMock,
Expand Down Expand Up @@ -590,10 +604,10 @@ public function isRowValidData()
'product_type' => 'downloadable',
'name' => 'Downloadable Product 2',
'downloadable_samples' => 'group_title=Group Title Samples, title=Title 1, file=media/file.mp4'
.',sortorder=1|group_title=Group Title, title=Title 2, url=media/file2.mp4,sortorder=0',
. ',sortorder=1|group_title=Group Title, title=Title 2, url=media/file2.mp4,sortorder=0',
'downloadable_links' => 'group_title=Group Title Links, title=Title 1, price=10,'
.' downloads=unlimited, file=media/file.mp4,sortorder=1|group_title=Group Title,'
.' title=Title 2, price=10, downloads=unlimited, url=media/file2.mp4,sortorder=0',
. ' downloads=unlimited, file=media/file.mp4,sortorder=1|group_title=Group Title,'
. ' title=Title 2, price=10, downloads=unlimited, url=media/file2.mp4,sortorder=0',
],
'row_num' => 3,
'is_new_product' => true,
Expand Down Expand Up @@ -622,10 +636,10 @@ public function isRowValidData()
'product_type' => 'downloadable',
'name' => 'Downloadable Product 2',
'downloadable_samples' => 'group_title=Group Title Samples, title=Title 1, file=media/file.mp4'
.',sortorder=1|group_title=Group Title, title=Title 2, url=media/file2.mp4,sortorder=0',
. ',sortorder=1|group_title=Group Title, title=Title 2, url=media/file2.mp4,sortorder=0',
'downloadable_links' => 'group_title=Group Title Links, title=Title 1, price=10,'
.' downloads=unlimited, file=media/file.mp4,sortorder=1|group_title=Group Title,'
.' title=Title 2, price=10, downloads=unlimited, url=media/file2.mp4,sortorder=0',
. ' downloads=unlimited, file=media/file.mp4,sortorder=1|group_title=Group Title,'
. ' title=Title 2, price=10, downloads=unlimited, url=media/file2.mp4,sortorder=0',
],
'row_num' => 5,
'is_new_product' => true,
Expand All @@ -638,10 +652,10 @@ public function isRowValidData()
'product_type' => 'downloadable',
'name' => 'Downloadable Product 2',
'downloadable_samples' => 'group_title=Group Title Samples, title=Title 1, file=media/file.mp4'
.',sortorder=1|group_title=Group Title, title=Title 2, url=media/file2.mp4,sortorder=0',
. ',sortorder=1|group_title=Group Title, title=Title 2, url=media/file2.mp4,sortorder=0',
'downloadable_links' => 'group_title=Group Title Links, title=Title 1, price=10,'
.' downloads=unlimited, file=media/file.mp4,sortorder=1|group_title=Group Title,'
.' title=Title 2, price=10, downloads=unlimited, url=media/file2.mp4,sortorder=0',
. ' downloads=unlimited, file=media/file.mp4,sortorder=1|group_title=Group Title,'
. ' title=Title 2, price=10, downloads=unlimited, url=media/file2.mp4,sortorder=0',
],
'row_num' => 6,
'is_new_product' => true,
Expand Down Expand Up @@ -685,15 +699,15 @@ public function testSetUploaderDirFalse($newSku, $bunch, $allowImport, $parsedOp
)->willReturn([]);

$metadataPoolMock = $this
->createPartialMock(\Magento\Framework\EntityManager\MetadataPool::class, ['getLinkField', 'getMetadata']);
->createPartialMock(MetadataPool::class, ['getLinkField', 'getMetadata']);
$metadataPoolMock->expects($this->any())->method('getMetadata')->willReturnSelf();
$metadataPoolMock->expects($this->any())->method('getLinkField')->willReturn('entity_id');
$this->downloadableHelper->expects($this->atLeastOnce())
->method('fillExistOptions')->willReturn($parsedOptions['link']);
$this->uploaderHelper->method('isFileExist')->willReturn(false);

$this->downloadableModelMock = $this->objectManagerHelper->getObject(
\Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable::class,
Downloadable::class,
[
'attrSetColFac' => $this->attrSetColFacMock,
'prodAttrColFac' => $this->prodAttrColFacMock,
Expand All @@ -708,7 +722,7 @@ public function testSetUploaderDirFalse($newSku, $bunch, $allowImport, $parsedOp
$this->entityModelMock->expects($this->at(1))->method('getNextBunch')->will($this->returnValue($bunch));
$this->entityModelMock->expects($this->at(2))->method('getNextBunch')->will($this->returnValue(null));
$this->entityModelMock->expects($this->any())->method('isRowAllowedToImport')->willReturn($allowImport);
$exception = new \Magento\Framework\Exception\LocalizedException(new \Magento\Framework\Phrase('Error'));
$exception = new LocalizedException(new Phrase('Error'));
$this->uploaderMock->expects($this->any())->method('move')->will($this->throwException($exception));
$this->entityModelMock->expects($this->exactly(2))->method('addRowError');
$result = $this->downloadableModelMock->saveData();
Expand Down Expand Up @@ -808,7 +822,7 @@ public function testPrepareAttributesWithDefaultValueForSave()
]
);
$this->downloadableModelMock = $this->objectManagerHelper->getObject(
\Magento\DownloadableImportExport\Model\Import\Product\Type\Downloadable::class,
Downloadable::class,
[
'attrSetColFac' => $this->attrSetColFacMock,
'prodAttrColFac' => $this->prodAttrColFacMock,
Expand Down