#27500 Prepare ConfigurableProduct module Tests for PHPUnit 8 #27822

lbajsarowicz · 2020-04-12T00:21:26Z

Description (*)

Preparing PHPUnit Tests to run with PHPUnit 8.
PRs for each module is separated to make tests easier to merge.

Related Pull Requests

Fixed Issues (if relevant)

Unit Tests incompatible with PHPUnit 8 #27500

Manual testing scenarios (*)

N/A

Questions or comments

PR #27701 needs to be merged first (otherwise PHPUnit tests fail)

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-04-12T00:21:28Z

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

slavvka · 2020-04-16T02:04:41Z

The cause of failure is:

18:23:59 FPHP Fatal error:  Interface 'Magento\Catalog\Api\Data\ProductExtensionInterface' not found in /var/www/html/app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/ProductExtensionAttributes.php on line 10

app/code/Magento/ConfigurableProduct/Test/Unit/Observer/HideUnsupportedAttributeTypesTest.php

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Quote/Item/CartItemProcessorTest.php

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/SaveHandlerTest.php

…onfigurableProduct

ihor-sviziev · 2020-04-17T14:32:13Z

@slavvka could you give some info why static tests failing?

slavvka · 2020-04-17T15:34:42Z

@magento run all tests

slavvka · 2020-04-17T16:16:25Z

@ihor-sviziev

19:08:55 .PHP Fatal error:  Interface 'Magento\Catalog\Api\Data\ProductExtensionInterface' not found in /var/www/html/app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/ProductExtensionAttributes.php on line 12

…onfigurableProduct

lbajsarowicz · 2020-04-18T19:48:58Z

@slavvka Is that message from PHPStan?

slavvka · 2020-04-19T02:01:42Z

@lbajsarowicz no, phpunit when running PHP static tests, only on B2B:

        <testsuite name="PHP Coding Standard Verification">
            <file>testsuite/Magento/Test/Php/LiveCodeTest.php</file>
        </testsuite>
        <testsuite name="Xss Unsafe Output Test">
            <file>testsuite/Magento/Test/Php/XssPhtmlTemplateTest.php</file>
        </testsuite>

slavvka · 2020-04-19T02:02:05Z

Also here are the same warnings:

14:59:34 There were 13 warnings:
14:59:34 
14:59:34 1) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "missing_previous_and_new_status" (null, null, null)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 2) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "missing_previous_status_and_subscribe" (null, true, true)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 3) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "new_unsubscribed_value_and_missing_previous_status" (null, false, null)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 4) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "previous_subscribed_status_without_new_value" (1, null, null)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 5) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "same_subscribed_previous_and_new_status" (1, true, null)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 6) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "unsubscribe_previously_subscribed_customer" (1, false, false)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 7) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "previously_unsubscribed_status_without_new_value" (3, null, null)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 8) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "subscribe_previously_unsubscribed_customer" (3, true, true)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 9) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "same_unsubscribed_previous_and_new_status" (3, false, null)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 10) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "previous_unconfirmed_status_without_new_value" (4, null, true)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 11) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "subscribe_previously_unconfirmed_status" (4, true, true)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 12) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "unsubscribe_previously_unconfirmed_status" (4, false, true)
14:59:34 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
14:59:34 
14:59:34 13) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterGetByIdCreatesExtensionAttributes
14:59:34 Trying to configure method "setIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static

…onfigurableProduct

slavvka · 2020-04-22T14:04:42Z

Static only in B2B:

16:48:03 .PHP Fatal error:  Interface 'Magento\Catalog\Api\Data\ProductExtensionInterface' not found in /var/www/html/app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/ProductExtensionAttributes.php on line 12

slavvka · 2020-04-22T14:05:46Z

Unit CE, EE, B2B

16:49:52 There were 13 warnings:
16:49:52 
16:49:52 1) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "missing_previous_and_new_status" (null, null, null)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 2) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "missing_previous_status_and_subscribe" (null, true, true)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 3) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "new_unsubscribed_value_and_missing_previous_status" (null, false, null)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 4) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "previous_subscribed_status_without_new_value" (1, null, null)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 5) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "same_subscribed_previous_and_new_status" (1, true, null)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 6) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "unsubscribe_previously_subscribed_customer" (1, false, false)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 7) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "previously_unsubscribed_status_without_new_value" (3, null, null)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 8) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "subscribe_previously_unsubscribed_customer" (3, true, true)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 9) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "same_unsubscribed_previous_and_new_status" (3, false, null)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 10) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "previous_unconfirmed_status_without_new_value" (4, null, true)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 11) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "subscribe_previously_unconfirmed_status" (4, true, true)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 12) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterSave with data set "unsubscribe_previously_unconfirmed_status" (4, false, true)
16:49:52 Trying to configure method "getIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static
16:49:52 
16:49:52 13) Magento\Newsletter\Test\Unit\Model\Plugin\CustomerPluginTest::testAfterGetByIdCreatesExtensionAttributes
16:49:52 Trying to configure method "setIsSubscribed" which cannot be configured because it does not exist, has not been specified, is final, or is static

…onfigurableProduct

slavvka · 2020-04-23T18:04:34Z

12:36:57 PHP Fatal error:  Declaration of Magento\Banner\Test\Unit\Block\Adminhtml\Widget\Instance\Edit\Chooser\ContainerTest::setUp() must be compatible with Magento\Widget\Test\Unit\Block\Adminhtml\Widget\Instance\Edit\Chooser\AbstractContainerTest::setUp(): void in /var/www/html/app/code/Magento/Banner/Test/Unit/Block/Adminhtml/Widget/Instance/Edit/Chooser/ContainerTest.php on line 15

slavvka · 2020-04-23T18:05:25Z

Static tests

12:41:47 .PHP Fatal error:  Interface 'Magento\Catalog\Api\Data\ProductExtensionInterface' not found in /var/www/html/app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/ProductExtensionAttributes.php on line 12

slavvka · 2020-04-23T22:01:47Z

@magento run all tests

ihor-sviziev · 2020-04-24T14:16:49Z

From my perspective this pr could be merged, as I understood issue inside EE or b2b version

m2-assistant · 2020-04-24T15:43:59Z

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#27500 Prepare ConfigurableProduct module Tests for PHPUnit 8

c29aadc

magento-engcom-team added Component: ConfigurableProduct Release Line: 2.4 labels Apr 12, 2020

ghost added the Progress: pending review label Apr 12, 2020

magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Apr 12, 2020

magento#27500 Fix static checks

6d922fe

dmytro-ch self-assigned this Apr 15, 2020

slavvka added Component: AdvancedPricingImportExport Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Component: AdvancedPricingImportExport labels Apr 15, 2020

ihor-sviziev self-assigned this Apr 16, 2020

Merge branch '2.4-develop' into phpunit8/module-ConfigurableProduct

2e9a643

ihor-sviziev mentioned this pull request Apr 16, 2020

#27500 Prepare Catalog module Tests for PHPUnit 8 #27823

Merged

4 tasks

ghost added Progress: review and removed Progress: pending review labels Apr 16, 2020

slavvka changed the base branch from 2.4-develop to phpunit8 April 16, 2020 14:49

ihor-sviziev requested changes Apr 16, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: review labels Apr 16, 2020

lbajsarowicz added 3 commits April 16, 2020 22:29

Merge remote-tracking branch 'origin/phpunit8' into phpunit8/module-C…

a7561ed

…onfigurableProduct

magento#27500 Code Review adjustments to ConfigurableProduct module

45c87da

magento#27500 Code Review adjustments to ConfigurableProduct module

f829ab0

ghost added Progress: review and removed Progress: needs update labels Apr 17, 2020

Merge remote-tracking branch 'origin/phpunit8' into phpunit8/module-C…

d1f2f03

…onfigurableProduct

Merge remote-tracking branch 'origin/phpunit8' into phpunit8/module-C…

868d898

…onfigurableProduct

Merge remote-tracking branch 'origin/phpunit8' into phpunit8/module-C…

9ff82b8

…onfigurableProduct

ihor-sviziev approved these changes Apr 24, 2020

View reviewed changes

ghost added Progress: waiting related PRs and removed Progress: review labels Apr 24, 2020

slavvka merged commit 7e14469 into magento:phpunit8 Apr 24, 2020

magento-engcom-team mentioned this pull request May 1, 2020

Unit Tests incompatible with PHPUnit 8 #27500

Closed

#27500 Prepare ConfigurableProduct module Tests for PHPUnit 8 #27822

#27500 Prepare ConfigurableProduct module Tests for PHPUnit 8 #27822

Uh oh!

Conversation

lbajsarowicz commented Apr 12, 2020 • edited by slavvka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Apr 12, 2020

Uh oh!

slavvka commented Apr 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ihor-sviziev commented Apr 17, 2020

Uh oh!

slavvka commented Apr 17, 2020

Uh oh!

slavvka commented Apr 17, 2020

Uh oh!

lbajsarowicz commented Apr 18, 2020

Uh oh!

slavvka commented Apr 19, 2020

Uh oh!

slavvka commented Apr 19, 2020

Uh oh!

slavvka commented Apr 22, 2020

Uh oh!

slavvka commented Apr 22, 2020

Uh oh!

slavvka commented Apr 23, 2020

Uh oh!

slavvka commented Apr 23, 2020

Uh oh!

slavvka commented Apr 23, 2020

Uh oh!

ihor-sviziev commented Apr 24, 2020

Uh oh!

m2-assistant bot commented Apr 24, 2020

Uh oh!

Uh oh!

lbajsarowicz commented Apr 12, 2020 •

edited by slavvka

Loading