ISSUE#21446: Removed unnecessary files to move them to Magento Commerce

[andrewbess]

Description (*)

This PR partially fixes the issue#21446. It removes the less files of the adminhtml area and some less files from frontend area (that haven't been separated for different frontend themes) to move them to Magento Commerce

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/173

Fixed Issues (if relevant)

1. Fixes Community themes contain resources for Commerce edition modules #21446: Community themes contain resources for Commerce edition modules

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

@magento run Static Tests

[ihor-sviziev]

Hi @slavvka @lenaorobei ,
Could you help to understand why static test fails?

[slavvka]

@ihor-sviziev

01:43:04 1) Magento\Test\Less\LiveCodeTest::testCodeStyle
01:43:04 Magento\Framework\Exception\LocalizedException: The following patterns didn't return any result:
01:43:04 app/design/adminhtml/Magento/backend/Magento_GiftRegistry/web/css/source/_module-old.less
01:43:04 
01:43:04 /var/www/html/lib/internal/Magento/Framework/App/Utility/Files.php:1617
01:43:04 /var/www/html/dev/tests/static/testsuite/Magento/Test/Less/LiveCodeTest.php:76
01:43:04 /var/www/html/dev/tests/static/testsuite/Magento/Test/Less/LiveCodeTest.php:57

[ihor-sviziev]

Hi @andrewbess,
Could you investigate why static test fails and adjust your PR or test itself? As for me message isn't clear at all, but definitely there should be some meaning behind that failure.

Thank you!

[ihor-sviziev]

Hi @andrewbess,
Will you be able to update your PR?

[ihor-sviziev]

@andrewbess I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[m2-assistant]

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[andrewbess]

@magento run all tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Static Tests

[ihor-sviziev]

Hi @andrewbess,
Unfortunately static tests still fails, please review and fix them

[ihor-sviziev]

I think this change could break some functionality related to ee / b2b, so added milestone 2.5.

[ihor-sviziev]

@andrewbess will you be able to update your PR?

[ihor-sviziev]

@andrewbess I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[friendscottn]

This issue probably shouldn't be closed, but if you arrived here like me because you working on performance and removing unused css, take a look at this related issue #24666. If the issue has not be resolved in your version of Magento there's a patch to fix the issue.