Skip to content

#27503 : MFTF: Acceptance tests break the naming convention (Indexer + Backup) #27515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="deleteBackup">
<actionGroup name="AdminBackupDeleteActionGroup">
<annotations>
<description>Deletes a Backup using provided Backup Entity.</description>
</annotations>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminBackupIndexPageOpenActionGroup">
<amOnPage url="{{AdminBackupIndexPage.url}}" stepKey="navigateToBackupIndexPage"/>
<waitForPageLoad stepKey="waitForBackupIndexPageLoad"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="deleteBackup" extends="AdminBackupDeleteActionGroup" deprecated="Use DeleteBackupActionGroup"/>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<pages xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/PageObject.xsd">
<page name="BackupIndexPage" url="/backup/index/" area="admin" module="Magento_Backup">
<page name="AdminBackupIndexPage" url="/backup/index/" area="admin" module="Magento_Backup">
<section name="AdminMainActionsSection"/>
<section name="AdminGridTableSection"/>
<section name="AdminCreateBackupFormSection"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>

<!--Go to backup index page-->
<amOnPage url="{{BackupIndexPage.url}}" stepKey="goToBackupPage"/>
<waitForPageLoad stepKey="waitForBackupPage"/>
<actionGroup ref="AdminBackupIndexPageOpenActionGroup" stepKey="navigateToBackupPage"/>

<!--Create system backup-->
<actionGroup ref="CreateSystemBackupActionGroup" stepKey="createSystemBackup"/>
Expand All @@ -39,17 +38,17 @@
<actionGroup ref="CreateDatabaseBackupActionGroup" stepKey="createDatabaseBackup"/>

<!--Delete system backup-->
<actionGroup ref="deleteBackup" stepKey="deleteSystemBackup">
<actionGroup ref="AdminBackupDeleteActionGroup" stepKey="deleteSystemBackup">
<argument name="backup" value="SystemBackup"/>
</actionGroup>

<!--Delete database/media backup-->
<actionGroup ref="deleteBackup" stepKey="deleteMediaBackup">
<actionGroup ref="AdminBackupDeleteActionGroup" stepKey="deleteMediaBackup">
<argument name="backup" value="MediaBackup"/>
</actionGroup>

<!--Delete database backup-->
<actionGroup ref="deleteBackup" stepKey="deleteDatabaseBackup">
<actionGroup ref="AdminBackupDeleteActionGroup" stepKey="deleteDatabaseBackup">
<argument name="backup" value="DatabaseBackup"/>
</actionGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<deleteData createDataKey="simpleProduct1" stepKey="deleteSimpleProduct1"/>
<deleteData createDataKey="categoryFirst" stepKey="deleteCategory"/>
<comment userInput="The test was moved to elasticsearch suite" stepKey="resetCatalogSearchConfiguration"/>
<actionGroup ref="updateIndexerOnSave" stepKey="resetIndexerBackToOriginalState">
<actionGroup ref="AdminIndexerSetUpdateOnSaveActionGroup" stepKey="resetIndexerBackToOriginalState">
<argument name="indexerName" value="catalogsearch_fulltext"/>
</actionGroup>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutOfAdmin"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminIndexerSetUpdateOnSaveActionGroup">
<annotations>
<description>Goes to the Index Management page. Checks the provided Indexer Name. Selects 'Update on Save'. Clicks on Submit.</description>
</annotations>
<arguments>
<argument name="indexerName" type="string"/>
</arguments>

<amOnPage url="{{_ENV.MAGENTO_BACKEND_NAME}}/indexer/indexer/list/" stepKey="amOnIndexManagementPage2"/>
<waitForPageLoad stepKey="waitForIndexManagementPageToLoad2"/>
<click selector="{{AdminIndexManagementSection.indexerCheckbox(indexerName)}}" stepKey="selectIndexer2"/>
<selectOption selector="{{AdminIndexManagementSection.massActionSelect}}" userInput="change_mode_onthefly" stepKey="selectUpdateOnSave"/>
<click selector="{{AdminIndexManagementSection.massActionSubmit}}" stepKey="submitIndexerForm2"/>
<!-- No re-indexing is done as part of this actionGroup since the test required no re-indexing -->
<waitForPageLoad stepKey="waitForSave2"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="updateIndexerBySchedule">
<actionGroup name="UpdateIndexerBySchedule">
<annotations>
<description>Goes to the Index Management page. Checks the provided Indexer Name. Selects 'Update by Schedule'. Clicks on Submit.</description>
</annotations>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,5 @@
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="updateIndexerOnSave">
<annotations>
<description>Goes to the Index Management page. Checks the provided Indexer Name. Selects 'Update on Save'. Clicks on Submit.</description>
</annotations>
<arguments>
<argument name="indexerName" type="string"/>
</arguments>

<amOnPage url="{{_ENV.MAGENTO_BACKEND_NAME}}/indexer/indexer/list/" stepKey="amOnIndexManagementPage2"/>
<waitForPageLoad stepKey="waitForIndexManagementPageToLoad2"/>
<click selector="{{AdminIndexManagementSection.indexerCheckbox(indexerName)}}" stepKey="selectIndexer2"/>
<selectOption selector="{{AdminIndexManagementSection.massActionSelect}}" userInput="change_mode_onthefly" stepKey="selectUpdateOnSave"/>
<click selector="{{AdminIndexManagementSection.massActionSubmit}}" stepKey="submitIndexerForm2"/>
<!-- No re-indexing is done as part of this actionGroup since the test required no re-indexing -->
<waitForPageLoad stepKey="waitForSave2"/>
</actionGroup>
<actionGroup name="updateIndexerOnSave" extends="AdminIndexerSetUpdateOnSaveActionGroup" deprecated="Use AdminIndexerSetUpdateOnSaveActionGroup"/>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<stories value="Menu Navigation"/>
<title value="Admin system index management grid change test"/>
<description value="Verify changes in 'Schedule column' on system index management"/>
<severity value="CRITICAL"/>
</annotations>
<before>
<createData entity="_defaultCategory" stepKey="createCategory"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,10 @@
</actionGroup>

<!--Go to backup index page and verify AssertBackupInGrid-->
<amOnPage url="{{BackupIndexPage.url}}" stepKey="goToBackupIndexPage"/>
<waitForPageLoad stepKey="waitForBackupIndexPageLoad"/>
<actionGroup ref="AdminBackupIndexPageOpenActionGroup" stepKey="navigateToBackupPage"/>
<see selector="{{AdminGridTableSection.backupNameColumn}}" userInput="{{WebSetupWizardBackup.name}}" stepKey="seeBackupInGrid"/>
<!--Delete database backup-->
<actionGroup ref="deleteBackup" stepKey="deleteDatabaseBackup">
<actionGroup ref="AdminBackupDeleteActionGroup" stepKey="deleteDatabaseBackup">
<argument name="backup" value="WebSetupWizardBackup"/>
</actionGroup>
</test>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@
</actionGroup>

<!--Go to backup index page and verify AssertBackupInGrid-->
<amOnPage url="{{BackupIndexPage.url}}" stepKey="goToBackupIndexPage"/>
<waitForPageLoad stepKey="waitForBackupIndexPageLoad"/>
<actionGroup ref="AdminBackupIndexPageOpenActionGroup" stepKey="navigateToBackupPage"/>
<see selector="{{AdminGridTableSection.backupNameColumn}}" userInput="{{WebSetupWizardBackup.name}}" stepKey="seeBackupInGrid"/>
<!--Delete database backup-->
<actionGroup ref="deleteBackup" stepKey="deleteDatabaseBackup">
<actionGroup ref="AdminBackupDeleteActionGroup" stepKey="deleteDatabaseBackup">
<argument name="backup" value="WebSetupWizardBackup"/>
</actionGroup>

Expand Down