Skip to content

FIX: wrong img size attributes #27034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

FIX: wrong img size attributes #27034

wants to merge 3 commits into from

Conversation

GrimLink
Copy link
Member

@GrimLink GrimLink commented Feb 26, 2020

Description (*)

Since commit da7a64f#diff-eed94ca7983b385a07b8fb5ee2dbc20d the html attributes on the image_with_borders.phtml have changed from;

  • width to max-width
  • height to max-height.

This is off course not valid html.
And will not work.

Fixes

This will use the right html width and height tags and improve rendering if used correctly.

Manual testing scenarios (*)

No testing required.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @GrimLink. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev
Copy link
Contributor

Hi @GrimLink,
Thank you for your contribution!

Right now we have pull request that includes the same changes and it's already approved #27033.

I'm closing this Pull Request as duplicate of #27033

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @GrimLink, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@GrimLink GrimLink deleted the bugfix/wrong-img-size-attribute branch April 24, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants