Skip to content

[FTR] Migrate from ZF2 components to Laminas components #26883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Feb 14, 2020

Description (*)

This PR replace ZF2 components dependency to Laminas components

Related Pull Requests

  1. Migrate ZF2 components to Laminas components #26436

Fixed Issues (if relevant)

  1. Consider migrating from zendframework to laminas community-features#229
  2. Update zendframework to laminas #26335

Manual testing scenarios (*)

Questions or comments

Due to 2 weeks inactivity on original PR I opened this PR with resolved conflicts

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 14, 2020

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Den4ik
Copy link
Contributor Author

Den4ik commented Feb 14, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, here is your new Magento instance.
Admin access: https://pr-26883.instances.magento-community.engineering/admin_f845
Login: 0101802e Password: 18905fb30f94
Instance will be terminated in up to 3 hours.

@lenaorobei
Copy link
Contributor

This improvement is already done in the scope of #26883

I think you should consider working with @ihor-sviziev if something is missing.

@Den4ik
Copy link
Contributor Author

Den4ik commented Feb 14, 2020

HI @lenaorobei
Thanks for remark. But I opened this PR due to inactivity in original PR.
Unfortunately I don't have permissions for committing to @ihor-sviziev repository.
Please close this PR if updates will be provided at #26436

@Den4ik Den4ik force-pushed the ftr/zf2-to-laminas branch from 9dcab4e to 178eca5 Compare February 14, 2020 22:25
@ihor-sviziev
Copy link
Contributor

Hi @Den4ik,
In my original PR all CE tests were passing and I hadn’t any issues. There were issues with b2b and EE versions, but as I don’t have access to them - I can’t fix them.

@Den4ik Den4ik closed this Feb 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2020

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 15, 2020

I just wrote an update in my PR #26436 to highlight the current status

@Den4ik Den4ik deleted the ftr/zf2-to-laminas branch February 20, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants