Skip to content

fix/26672 : fix space in products URLKey #26881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ramesh-durairajaram
Copy link

Description (*)

  • User entered URL Key is not getting formatted
    i.e: When user enter a 'simple - product' in URL Key field, it is not getting formatted into 'simple-product'

Related Pull Requests

Fixed Issues (if relevant)

  1. Product url key allowing space into url #26672: Product url key allowing space into url

Manual testing scenarios (*)

  1. Try creating a product with user defined URL Key with space in it as mentioned in description
  2. On Saving, the product's URL key should get formatted by eliminating the space in it

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 14, 2020

Hi @ramesh-durairajaram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ramesh-durairajaram
Copy link
Author

@orlangur : Please validate this at the earliest.

@hostep
Copy link
Contributor

hostep commented Mar 10, 2020

Just FYI: It looks like this is already being fixed in #26506

@ramesh-durairajaram
Copy link
Author

closing the ticket. since @hostep has fixed the issue

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2020

Hi @ramesh-durairajaram, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants