Skip to content

#26612 Fix failure on Coupon Apply procedure when loading mask still visible #26614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2020
Merged

#26612 Fix failure on Coupon Apply procedure when loading mask still visible #26614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Checkout/Test/Mftf/Test/StorefrontApplyPromoCodeDuringCheckoutTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<argument name="shippingMethod" value="Flat Rate"/>
</actionGroup>

<!-- Click Apply Discount Code: section is expanded. Input promo code, apply and see success message -->
<!-- Click Apply Discount Code: section is expanded. Input promo code, apply and see success message -->
<actionGroup ref="StorefrontApplyDiscountCodeActionGroup" stepKey="applyCoupon">
<argument name="discountCode" value="$$createCouponForCartPriceRule.code$$"/>
</actionGroup>
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/SalesRule/Test/Mftf/ActionGroup/StorefrontApplyDiscountCodeActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<fillField selector="{{DiscountSection.DiscountInput}}" userInput="{{discountCode}}" stepKey="fillFieldDiscountCode"/>
<click selector="{{DiscountSection.ApplyCodeBtn}}" stepKey="clickToApplyDiscount"/>
<waitForElement selector="{{DiscountSection.DiscountVerificationMsg}}" time="30" stepKey="waitForDiscountToBeAdded"/>
<waitForLoadingMaskToDisappear stepKey="waitForLoadingFinished"/>
<see selector="{{DiscountSection.DiscountVerificationMsg}}" userInput="Your coupon was successfully applied" stepKey="assertDiscountApplyMessage"/>
</actionGroup>
</actionGroups>