[fixed My Wish List Product not showing properly between >768px and <…

[hitesh-wagento]

Description (*)

Fixed My Wish List Product not showing properly between >768px and <1023px

Fixed Issues (if relevant)

1. My Wish List Product not showing properly between >768px and <1023px #26543: My Wish List Product not showing properly between >768px and <1023px

Manual testing scenarios (*)

1. Login in frontend
2. Add 4-5 products in wishlist
3. Go to Wishlist page

Expected result

Products should show 3 items

Actual result

Products show 2 products and space right side

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ptylek]

Hello, @hitesh-wagento, thank you for your contribution.
I don't understand why did you choose those values for margin and width. Also later on, they are overwritten by width: 100% and margin: 0 anyway, aren't they?

[hitesh-wagento]

Hello, @hitesh-wagento, thank you for your contribution.
I don't understand why did you choose those values for margin and width. Also later on, they are overwritten by width: 100% and margin: 0 anyway, aren't they?

Hi @ptylek

I have applied margin as per desktop and >640px; and after <640px you can see 100% width not required margin.

Thanks

[ptylek]

Okay, I understand @hitesh-wagento. But why these values such as margin-left: 2%; padding: 5px; width: calc(~'(100% - 4%) / 3')? I couldn't find any other grid using these values. Aren't there any variables?

[hitesh-wagento]

Okay, I understand. But why these values such as margin-left: 2%; padding: 5px; width: calc(~'(100% - 4%) / 3')? I couldn't find any other grid using these values. Aren't there any variables?

Hi @ptylek

You can find this variable in category pages on a smaller size in the below CSS.
.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {

/Magento_Catalog/web/css/source/module/_listings.less

Thanks

[ptylek]

@hitesh-wagento, thanks for clarification, I added some comments

[ptylek]

Great, @hitesh-wagento! Thank you for your contribution.

[magento-engcom-team]

Hi @ptylek, thank you for the review.
ENGCOM-6723 has been created to process this Pull Request

[engcom-Hotel]

✔️ QA Passed

[hitesh-wagento]

#mm20in

[m2-assistant]

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.