Skip to content

Module xml extra end tag removed #26339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2020
Merged

Module xml extra end tag removed #26339

merged 2 commits into from
Feb 9, 2020

Conversation

tejash-wagento
Copy link
Contributor

@tejash-wagento tejash-wagento commented Jan 10, 2020 •
edited
Loading

Description (*)

Module xml extra end tag removed

Fixed Issues (if relevant)

  1. Code cleanup for module xml extra end tag removed #26338: Code cleanup for module xml extra end tag removed

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 10, 2020

Hi @tejash-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 10, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 10, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Jan 10, 2020
@dmytro-ch
Copy link
Contributor

Hi @tejash-wagento,
thank you for your contribution!
Please sign CLA, otherwise, we won't be able to process your pull request.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6573 has been created to process this Pull Request

lbajsarowicz
lbajsarowicz suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify thoroughly the dependencies :-)

app/code/Magento/AdvancedPricingImportExport/etc/module.xml Outdated
@@ -6,6 +6,5 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Magento_AdvancedPricingImportExport" >
</module>
<module name="Magento_AdvancedPricingImportExport" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML should not have space before /> or >

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space removed

app/code/Magento/Dhl/etc/module.xml Outdated
@@ -6,6 +6,5 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Magento_Dhl" >
</module>
<module name="Magento_Dhl" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dhl module depends on Config and Shipping (quick look).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space removed

app/code/Magento/Rss/etc/module.xml Outdated
@@ -6,6 +6,5 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Magento_Rss" >
</module>
<module name="Magento_Rss" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rss depends on Config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space removed

app/code/Magento/Ups/etc/module.xml Outdated
@@ -6,6 +6,5 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Magento_Ups" >
</module>
<module name="Magento_Ups" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups module depends on Config and Shipping (quick look).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space removed

@ghost ghost assigned lbajsarowicz Jan 10, 2020
@tejash-wagento
Copy link
Contributor Author

Hi @lbajsarowicz,

I have resolved issues.

@lbajsarowicz
Copy link
Contributor

Hi @lbajsarowicz,

I have resolved issues.

Add dependencies I've mentioned :-)

@ghost ghost assigned lenaorobei Feb 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6573 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 7, 2020
@engcom-Golf engcom-Golf self-assigned this Feb 7, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@slavvka slavvka mentioned this pull request Feb 9, 2020
Closed
4 tasks
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
ENGCOM-6573: Module xml extra end tag removed #26339
e899451
@magento-engcom-team magento-engcom-team merged commit 399fe8e into magento:2.4-develop Feb 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @tejash-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz requested changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@buskamuza buskamuza Awaiting requested review from buskamuza

@YevSent YevSent Awaiting requested review from YevSent

@melnikovi melnikovi Awaiting requested review from melnikovi

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@lenaorobei lenaorobei

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: AdvancedPricingImportExport Component: Dhl Component: Rss Component: Translation Component: Ups Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tejash-wagento @dmytro-ch @magento-engcom-team @lbajsarowicz @engcom-Delta @lenaorobei @engcom-Golf