Skip to content

[Framework] Fixing the caches that don't have no instance configured #26236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jan 2, 2020

Description (*)

This PR fixes the caches that don't no instance configured, as it's an optional argument.

Fixed Issues (if relevant)

  1. Cache type without "instance" causes exception when disabling the module through "Cache Management" in the backend #26224: Cache type without "instance" causes exception

Manual testing scenarios (*)

  1. Create a cache type using "cache.xml" without the "instance" argument
<config .../>
    <type name="exceptional_cache_type">
        <label>Exceptional Cache Type</label>
        <description>An exceptional cache type using a quantum computer</description>
    </type>
</config>
  1. Go to "System > Cache Management" in the backend
  2. Check the checkbox of the cache type "Exceptional Cache Type"
  3. Select "Disable" and click "Submit"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 requested a review from buskamuza as a code owner January 2, 2020 11:05
@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 2, 2020
@rogyar rogyar self-assigned this Jan 2, 2020
@rogyar
Copy link
Contributor

rogyar commented Jan 2, 2020

Hi @eduard13. Thank you for your collaboration. Please, join the discussion in the original issue. We have one more option here: throw an exception with the particular message instead of accepting a cache type with no implementation. But this point needs to be discussed additionally. I haven't found a use case for a cache type with no implementation

@rogyar
Copy link
Contributor

rogyar commented Jan 6, 2020

Hey @eduard13. I'm putting this PR on hold for now. We are going to discuss this topic internally. If you refer to the original issue, this case is not as straight forward as it seems to be.

Thank you.

@eduard13
Copy link
Contributor Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your Magento instance.
Admin access: https://i-26236-2-4-develop.instances.magento-community.engineering/admin_c85e
Login: 2d51cad3 Password: cf495e4770f9
Instance will be terminated in up to 3 hours.

@eduard13
Copy link
Contributor Author

Closing in favor of #26933.

@eduard13 eduard13 closed this Feb 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@eduard13 eduard13 deleted the 2.4-develop-cache-instance branch February 28, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants