Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] : Additional class option added for masonry grid #26200

Conversation

konarshankar07
Copy link
Contributor

Description (*)

This PR is regarding ASI (adobe stock integration) repo issue in which we need to require add some additional classes which can be useful for styling masonry grid with unique class

Fixed Issues (if relevant)

  1. Update media gallery grid styles to match the mockups adobe-stock-integration#828: Update media gallery grid styles to match the mockups

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 28, 2019

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Dec 28, 2019
@rogyar rogyar added Component: Ui Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6526 has been created to process this Pull Request

@konarshankar07 konarshankar07 changed the title Additional class option added for masonry grid [WIP] : Additional class option added for masonry grid Dec 28, 2019
@engcom-Bravo engcom-Bravo self-assigned this Jan 9, 2020
@engcom-Bravo engcom-Bravo removed their assignment Jan 9, 2020
@sivaschenko
Copy link
Member

@konarshankar07 I think these changes are not necessary, please see the conversation here magento/adobe-stock-integration#828 (comment)

@m2-assistant
Copy link

m2-assistant bot commented Jan 24, 2020

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants