Skip to content

#20463 Fix order summary view details label misalign #25785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mfickers
Copy link
Contributor

Description (*)

This fixes possible misalignment of "View Details" label for configurable products in the order summary, which happens on tablet-sized screens, especially just above the mobile breakpoint (width of 769px).

Fixed Issues (if relevant)

  1. On order sumary view details label misalign on tablet #20463: On order sumary view details label misalign on tablet

Manual testing scenarios (*)

  1. Add configurable product to cart
  2. Go to checkout shipping step
  3. "View Details" label of order summary items should not misalign on desktop screens of varying screen widths, especially 769px.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @mfickers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned krzksz Nov 28, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6348 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you did changes for Luma theme, does it look ok in Blank?

@mfickers
Copy link
Contributor Author

I updated the PR to also include a similar fix for the same issue on Blank theme.

@mfickers mfickers requested a review from krzksz November 29, 2019 11:22
@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6348 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

The same results and in the Blank theme.

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2019

Hi @mfickers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Event: cd-cologne19 Partner: Basecom partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants