Skip to content

Fixed the usage of deprecated methods of Messagemanager #25782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 3, 2019
Merged

Fixed the usage of deprecated methods of Messagemanager #25782

merged 10 commits into from
Dec 3, 2019

Conversation

subash-natarajan
Copy link
Contributor

@subash-natarajan subash-natarajan commented Nov 28, 2019 •
edited
Loading

Description

  • Fixed the usage of deprecated methods of MessageManager in Magento_Customer
  • Fixed appropriate PHPUnit tests

Manual testing scenarios

  • Only changed the deprecated methods

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @subash-natarajan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Nov 29, 2019
@ghost ghost assigned ihor-sviziev Nov 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6360 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@subash-natarajan thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Nov 29, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 29, 2019
magento-engcom-team pushed a commit that referenced this pull request Dec 3, 2019
@VladimirZaets
ENGCOM-6360: Fixed the usage of deprecated methods of Messagemanager #…
49606f1 
…25782
@magento-engcom-team magento-engcom-team merged commit 6f35328 into magento:2.3-develop Dec 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @subash-natarajan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
@VladimirZaets VladimirZaets mentioned this pull request Apr 9, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Customer Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
5 participants
@subash-natarajan @magento-engcom-team @engcom-Alfa @ihor-sviziev @engcom-Foxtrot