Skip to content

Update system.xml #25760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Update system.xml #25760

merged 1 commit into from
Dec 3, 2019

Conversation

Nagamaiah007
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2 Link (terms and conditions) is not opening new tab. Missing target="_blank" for anchor tag. #25757: Link (terms and conditions) is not opening new tab. Missing target="_blank" for anchor tag.

Manual testing scenarios (*)

  1. Go to Admin Page -> Menu
  2. Stores -> Settings -> Configuration -> General -> Advanced Reporting Page
  3. Link (terms and conditions) is opening in new tab with this fix

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2019

Hi @Nagamaiah007. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6339 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo engcom-Bravo self-assigned this Nov 27, 2019
@engcom-Bravo engcom-Bravo added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Nov 27, 2019
@engcom-Bravo
Copy link
Contributor

Hello @Nagamaiah007. Thank You for Your contribution. In order for us to be able to further process Your PR please cover it with an appropriate Auto-Test. Thank You.

@sidolov sidolov added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Nov 27, 2019
@VladimirZaets
Copy link
Contributor

@engcom-Bravo Hi, I think this PR not required to be covered by autotests

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-6339 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @Nagamaiah007, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Analytics Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants