Skip to content

Remove UserLockedException catch. #25692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2019
Merged

Remove UserLockedException catch. #25692

merged 1 commit into from
Nov 24, 2019

Conversation

drew7721
Copy link
Member

UserLockedException extends AuthenticationException and provides the same message, hence that catch is simply useless.

Description (*)

Remove redundant code form code base.

Questions or comments

None.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

`UserLockedException` extends `AuthenticationException` and provides the same message. These lines were useless.
@ghost
Copy link

ghost commented Nov 21, 2019

@drew7721 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @drew7721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6311 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo engcom-Bravo self-assigned this Nov 22, 2019
@engcom-Bravo engcom-Bravo added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Nov 22, 2019
@engcom-Bravo
Copy link
Contributor

✔️ Qa Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 22, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 22, 2019
@VladimirZaets
Copy link
Contributor

This PR is already covered by Magento/Customer/Test/Unit/Controller/Account/LoginPostTest.php test

@magento-engcom-team magento-engcom-team merged commit be319e9 into magento:2.3-develop Nov 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2019

Hi @drew7721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants