Skip to content

ISSUE 25680 Fixes console error on index page #25682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

duckchip
Copy link
Contributor

Description (*)

Since the requirejs-config block got removed in the layout file of the swagger index page, errors are thrown in the console log. To fix this, we also remove the theme.active.editor block for the swagger index page, which is defined in the Magento/Ui/view/base/layout/default.xml file.

Fixed Issues (if relevant)

  1. Console log error on Swagger page in 2.3.3 #25680: Console log error on Swagger page in 2.3.3

Manual testing scenarios (*)

  1. ... Go to /swagger endpoint of clean magento 2.3-develop instance
  2. ... Check the console log on the following error: require.config is not a function

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@duckchip duckchip requested a review from paliarush as a code owner November 21, 2019 10:01
@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @duckchip. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@duckchip
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @duckchip. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @duckchip, here is your new Magento instance.
Admin access: https://pr-25682.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@duckchip
Copy link
Contributor Author

Fix confirmed in testing environment

@kalpmehta kalpmehta self-assigned this Nov 21, 2019
@kalpmehta
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, here is your Magento instance.
Admin access: https://i-25682-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6307 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo engcom-Bravo self-assigned this Nov 21, 2019
@engcom-Bravo engcom-Bravo added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 21, 2019
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed.

@ghost ghost assigned krzksz Nov 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6307 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Nov 22, 2019

Hi @duckchip, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 22, 2019
@deepaksnair
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @deepaksnair. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@deepaksnair
Copy link
Contributor

deepaksnair commented Jun 3, 2020

@kalpmehta @krzksz
Hello all, I am still getting error on swagger landing page, I have attached a screenshot and error, please have a look, please assist if I am doing something wrong.

Magento version : 2.3.5-p1

[2020-06-03 17:01:46] main.ERROR: Unable to resolve the source file for 'frontend/Magento/luma/en_US/Magento_Swagger/swagger-ui/css/swagger-ui.css.map' [] []
[2020-06-03 17:01:46] main.CRITICAL: Unable to resolve the source file for 'frontend/Magento/luma/en_US/Magento_Swagger/swagger-ui/css/swagger-ui.css.map' [] []
[2020-06-03 17:01:47] main.ERROR: Unable to resolve the source file for 'frontend/Magento/luma/en_US/Magento_Swagger/swagger-ui/js/swagger-ui-bundle.js.map' [] []
[2020-06-03 17:01:47] main.CRITICAL: Unable to resolve the source file for 'frontend/Magento/luma/en_US/Magento_Swagger/swagger-ui/js/swagger-ui-bundle.js.map' [] []
[2020-06-03 17:01:47] main.ERROR: Unable to resolve the source file for 'frontend/Magento/luma/en_US/Magento_Swagger/swagger-ui/js/swagger-ui-standalone-preset.js.map' [] []
[2020-06-03 17:01:47] main.CRITICAL: Unable to resolve the source file for 'frontend/Magento/luma/en_US/Magento_Swagger/swagger-ui/js/swagger-ui-standalone-preset.js.map' [] []

Screenshot from 2020-06-03 22-28-42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants