Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647 #25648

edenduong · 2019-11-19T08:56:09Z

Description (*)

Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome #25647: Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647

Fixed Issues (if relevant)

Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome #25647: Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647

Manual testing scenarios (*)

Go to backend
Store->Configurations, Catalog->Inventory
Look at "Product Stock Options", "Minimum Qty Allowed in Shopping Cart"

Expected result

Gray color as Disabled

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-11-19T08:56:12Z

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

edenduong · 2019-11-19T09:29:18Z

@magento give me test instance

magento-engcom-team · 2019-11-19T09:29:24Z

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

edenduong · 2019-11-19T09:30:52Z

@magento give me test instance

magento-engcom-team · 2019-11-19T09:31:03Z

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-11-19T09:31:41Z

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-25648.instances.magento-community.engineering/admin
Login: admin Password: 123123q

rodrigowebjump · 2019-11-19T23:04:38Z

@magento give me test instance

magento-engcom-team · 2019-11-19T23:04:43Z

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-11-19T23:05:45Z

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-25648.instances.magento-community.engineering/admin
Login: admin Password: 123123q

rodrigowebjump · 2019-11-19T23:43:46Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-11-19T23:43:48Z

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-11-19T23:44:24Z

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-25648-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

rodrigowebjump · 2019-11-19T23:48:34Z

Hi @edenduong

In my test, the quantity is not displayed as disabled. Please could you check this too?

edenduong · 2019-11-20T00:41:12Z

Hi @rodrigowebjump ,

It is ok now. Please check it. Thanks!

ptylek · 2019-11-22T19:43:17Z

@magento give me test instance

magento-engcom-team · 2019-11-22T19:43:22Z

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-11-22T19:44:08Z

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-25648.instances.magento-community.engineering/admin
Login: admin Password: 123123q

ptylek · 2019-11-22T19:48:59Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-11-23T17:53:02Z

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-11-23T17:53:45Z

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-25648.instances.magento-community.engineering/admin
Login: admin Password: 123123q

ptylek · 2019-11-23T17:59:05Z

@edenduong Thanks for your contribution. I approved these changes.

magento-engcom-team · 2019-11-23T17:59:46Z

Hi @ptylek, thank you for the review.
ENGCOM-6321 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo · 2019-11-25T14:41:02Z

Hello @edenduong. Thanks for Your contribution. Here is a screenshot from a fresh install of the latest develop 2.3

Just as the Expected Result in the issue Your PR is going to fix. Could You please recheck it. Thank You.

edenduong · 2019-11-25T14:56:11Z

Hi @engcom-Bravo :

In 2.3-develop:

You can see All Group is white color background , not gray. It is disabled and should be Gray color like that:

Please check again. Thanks !

engcom-Bravo · 2019-11-25T15:09:59Z

Here You are @edenduong

I'll cloned my code an our ago from the engcom repository.

edenduong · 2019-11-25T15:16:53Z

@engcom-Bravo: I think the browser is different so in my screen, the style is different a bit. But you can see it your video, the style of "All group" must be the same like that:

Now it is different. You can see.

Thanks!

engcom-Bravo · 2019-11-26T11:37:52Z

✔️ QA Passed

…rt" on Google Chrome issue25647 #25648

m2-assistant · 2019-11-27T16:46:52Z

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Area: Design/Frontend Release Line: 2.3 tech-partners-contribution Technology Partner: Magestore labels Nov 19, 2019

edenduong force-pushed the 2.3-bugfix/wrong_css_issue25647 branch from a949d85 to f312a6c Compare November 19, 2019 09:28

magento deleted a comment from magento-engcom-team Nov 19, 2019

rodrigowebjump self-requested a review November 19, 2019 23:04

rodrigowebjump self-assigned this Nov 19, 2019

rodrigowebjump added the Progress: needs update label Nov 19, 2019

edenduong requested a review from sidolov November 21, 2019 14:32

ptylek self-requested a review November 22, 2019 19:43

ptylek approved these changes Nov 23, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Nov 23, 2019

magento-engcom-team added the Component: CatalogInventory label Nov 23, 2019

ptylek added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 23, 2019

engcom-Bravo self-assigned this Nov 25, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Nov 25, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Nov 25, 2019

ghost added Progress: extended testing and removed Progress: needs update labels Nov 26, 2019

engcom-Foxtrot self-assigned this Nov 26, 2019

ghost added Progress: accept and removed Progress: extended testing labels Nov 26, 2019

magento-engcom-team mentioned this pull request Nov 27, 2019

Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome #25647

Closed

magento-engcom-team pushed a commit that referenced this pull request Nov 27, 2019

ENGCOM-6321: Resolve Wrong Css at "Minimum Qty Allowed in Shopping Ca…

61a76d8

…rt" on Google Chrome issue25647 #25648

magento-engcom-team merged commit 0a4393c into magento:2.3-develop Nov 27, 2019

magento-engcom-team added this to the Release: 2.3.5 milestone Nov 27, 2019

sidolov added the Award: bug fix label Dec 15, 2019

Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647 #25648

Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647 #25648

Uh oh!

Conversation

edenduong commented Nov 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Expected result

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Nov 19, 2019

Uh oh!

edenduong commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

edenduong commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

rodrigowebjump commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

rodrigowebjump commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

magento-engcom-team commented Nov 19, 2019

Uh oh!

rodrigowebjump commented Nov 19, 2019

Uh oh!

edenduong commented Nov 20, 2019

Uh oh!

ptylek commented Nov 22, 2019

Uh oh!

magento-engcom-team commented Nov 22, 2019

Uh oh!

magento-engcom-team commented Nov 22, 2019

Uh oh!

ptylek commented Nov 22, 2019

Uh oh!

magento-engcom-team commented Nov 23, 2019

Uh oh!

magento-engcom-team commented Nov 23, 2019

Uh oh!

ptylek commented Nov 23, 2019

Uh oh!

magento-engcom-team commented Nov 23, 2019

Uh oh!

engcom-Bravo commented Nov 25, 2019

Uh oh!

edenduong commented Nov 25, 2019

Uh oh!

engcom-Bravo commented Nov 25, 2019

Uh oh!

edenduong commented Nov 25, 2019

Uh oh!

engcom-Bravo commented Nov 26, 2019

Uh oh!

m2-assistant bot commented Nov 27, 2019

Uh oh!

Uh oh!

edenduong commented Nov 19, 2019 •

edited

Loading