Skip to content

Adjust commands to the common style in the MediaGallery and change exception handle logic #25614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 24, 2019
Merged

Adjust commands to the common style in the MediaGallery and change exception handle logic #25614

merged 5 commits into from
Nov 24, 2019

Conversation

coderimus
Copy link
Contributor

@coderimus coderimus commented Nov 15, 2019 •
edited
Loading

Description (*)

Refactor commands with the proper exception handling, adjust commands to the common style used in the MediaGallery module, adjust tests.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2019

Hi @coderimus. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Nov 15, 2019
dmytro-ch
dmytro-ch requested changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coderimus, thank you for your contribution.
Could you please fix the mentioned issue?

dmytro-ch
dmytro-ch requested changes Nov 15, 2019
View reviewed changes
@coderimus coderimus requested a review from dmytro-ch November 16, 2019 11:04
@coderimus
Copy link
Contributor Author

Hi @dmytro-ch,
Thanks for your detail review: the most "tricky" errors are errors like a typo or a copy-paste the same thing twice :) Think that I cleaned them all)

dmytro-ch
dmytro-ch approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderimus, great, thank you for the updates! :)

@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6293 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Nov 18, 2019
@engcom-Delta engcom-Delta self-assigned this Nov 18, 2019
@engcom-Alfa engcom-Alfa removed their assignment Nov 18, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 18, 2019
lbajsarowicz
lbajsarowicz approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the new way of handling Exceptions. Kudos!

@ghost ghost assigned lbajsarowicz Nov 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6293 has been created to process this Pull Request

@sivaschenko sivaschenko changed the title REFACTORING: adjust commands to the common style in the MediaGallery and change exception handle logic Adjust commands to the common style in the MediaGallery and change exception handle logic Nov 20, 2019
@ghost ghost assigned sivaschenko Nov 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-6293 has been created to process this Pull Request

@coderimus
Copy link
Contributor Author

Hi @VladimirZaets, I saw this morning the conflict between this PR and current 2.3-develop. I resolved it by myself. Sorry, didn't know that after the PR approve this is not so good :( Please, pay attention to this when you will merge it.

magento-engcom-team pushed a commit that referenced this pull request Nov 24, 2019
@VladimirZaets
ENGCOM-6293: REFACTORING: adjust commands to the common style in the …
3a85d2c 
…MediaGallery and change exception handle logic #25614
@magento-engcom-team magento-engcom-team merged commit d282c10 into magento:2.3-develop Nov 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2019

Hi @coderimus, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@lbajsarowicz lbajsarowicz

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

@dmytro-ch dmytro-ch

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Community Insider: Magecom community-insider-contribution Component: MediaGallery Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
9 participants
@coderimus @magento-engcom-team @engcom-Delta @lbajsarowicz @sivaschenko @dmytro-ch @VladimirZaets @engcom-Alfa @engcom-Foxtrot