-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Adjust order address form to improve its styling #25548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aligns the looks of order address edit form with a new order creation shipping and billing address forms as they share block's class parent and logic. Fixes magento#19805
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @krzksz. Thank you for your request. I'm working on Magento instance for you |
Hi @krzksz, here is your new Magento instance. |
@magento run all tests |
Hi @krzksz, thank you for your contribution! |
Closing in favour of #25699 |
Hi @krzksz, thank you for your contribution! |
Description (*)
This PR aligns the looks of order address edit form with a new order creation shipping and billing
address forms as they share block's class parent and logic.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
My initial idea was to align the looks of the form to customer address edition which is opened inside a modal but it turns out that the same logic and blocks' parent is shared between existing and new order address edit forms so I just made sure they look similar:
Contribution checklist (*)