Skip to content

Adjust order address form to improve its styling #25548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Nov 10, 2019

Description (*)

This PR aligns the looks of order address edit form with a new order creation shipping and billing
address forms as they share block's class parent and logic.

Fixed Issues (if relevant)

  1. Sales order Address Information edit form layout design improvement. #19805: Sales order Address Information edit form layout design improvement.

Manual testing scenarios (*)

  1. Open order information and edit shipping or billing address.
  2. Address edit form styling shouldn't look broken and be simillar with new order creation address forms.

Questions or comments

My initial idea was to align the looks of the form to customer address edition which is opened inside a modal but it turns out that the same logic and blocks' parent is shared between existing and new order address edit forms so I just made sure they look similar:

obraz

obraz

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Aligns the looks of order address edit form with a new order creation shipping and billing
address forms as they share block's class parent and logic.

Fixes magento#19805
@krzksz krzksz requested a review from YevSent as a code owner November 10, 2019 14:31
@m2-assistant
Copy link

m2-assistant bot commented Nov 10, 2019

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor Author

krzksz commented Nov 10, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your new Magento instance.
Admin access: https://pr-25548.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 10, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 11, 2019
@dmytro-ch dmytro-ch self-requested a review November 11, 2019 07:54
@engcom-Alfa
Copy link
Contributor

@magento run all tests

@sdzhepa sdzhepa closed this Nov 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2019

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa reopened this Nov 11, 2019
@ghost ghost unassigned dmytro-ch and engcom-Alfa Nov 11, 2019
@dmytro-ch dmytro-ch self-assigned this Nov 11, 2019
@krzksz
Copy link
Contributor Author

krzksz commented Nov 24, 2019

Closing in favour of #25699

@krzksz krzksz closed this Nov 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2019

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Sales Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants