Skip to content

Fix issue #25517: Product item rating stars overlaps a hovered item on category page is… #25524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

speedy008
Copy link
Contributor

Description (*)

Product item rating stars overlaps a hovered item on category page issue resolved

Fixed Issues (if relevant)

  1. Product item rating stars overlaps a hovered item on category page #25517: Product item rating stars overlaps a hovered item on category page

Manual testing scenarios (*)

  1. Go to category with "Hot Sellers" product list set up (preferably Gear).
  2. Mouse hover on one of the product items, preferably the second to the left.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 8, 2019

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Karlasa Karlasa added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 8, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-6249 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@speedy008
Copy link
Contributor Author

@Karlasa Can u let me know why you have added cleanup tag in this PR.

@Karlasa Karlasa added the bugfix label Nov 8, 2019
@Karlasa
Copy link
Contributor

Karlasa commented Nov 8, 2019

Hi @speedy008 nothing you should worry about. Just labels for maintainers about PR context and achievements. You can read more about it in https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#base-achievements

magento-engcom-team pushed a commit that referenced this pull request Nov 14, 2019
@magento-engcom-team magento-engcom-team merged commit e891e81 into magento:2.3-develop Nov 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants