Skip to content

Cover an issue with removing bundle options #25466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2019
Merged

Cover an issue with removing bundle options #25466

merged 5 commits into from
Nov 7, 2019

Conversation

TomashKhamlai
Copy link
Contributor

@TomashKhamlai TomashKhamlai commented Nov 4, 2019

Description (*)

Cover an issue with removing bundle options #25468: Undefined index product_id
The test should fail. Then an issue will be created and the test is going to be skipped.

Fixed Issues (if relevant)

  1. n/a

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
@m2-assistant
Copy link

m2-assistant bot commented Nov 4, 2019

Hi @TomashKhamlai. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Nov 6, 2019
@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: MFTF test coverage and removed Progress: ready for testing labels Nov 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6234 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Nov 6, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 18, 2019
@ryanpalmerweb
Copy link
Contributor

Hi @TomashKhamlai

Just wanted to get some clarification as we are currently experiencing the same issue leading to the test failures on Magento 2.3.5-p2, which is that we can't remove some bundle product options without triggering the product_id error.

Why was the test removed rather than curing the issue causing the failure, or is there a commit somewhere which does fix this issue?

Thanks,
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants