Skip to content

Resolved Issue #25135 #25149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 18, 2019

Description

This PR resolves the below mentioned issue of duplicate asterisks indicating a single required field. This happens only when price is set for a custom option in the product. This has been resolved by unsetting the styles rendering the asterisk for the price fields and setting a single style rendering the asterisk for the label field.

Fixed Issues

  1. [UI Issue] when select Product with custom option (datetime) at backend #25135: [UI Issue] when select Product with custom option (datetime) at backend

Manual testing scenarios (from issue)

  1. Go to backend
  2. Create New Product with Custom Option (date time and required it)
  3. Create New Order at backend
  4. Add Product with custom option

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@drpayyne
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne, here is your new Magento instance.
Admin access: https://pr-25149.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@drpayyne drpayyne requested a review from sivaschenko October 18, 2019 13:35
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6122 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 23, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this pull request Dec 4, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 5, 2019
@VladimirZaets
Copy link
Contributor

Covered in the scope of #25915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants