Skip to content

Fixed issue #25039 Product detail did not scroll to review tab after click on 'Review' anchor link #25051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

gaurav-473
Copy link
Contributor

@gaurav-473 gaurav-473 commented Oct 14, 2019

Fixed issue #25039
Preconditions

  1. Magento 2.3.3

Steps to reproduce

  1. Go to product detail page
  2. Click on 'review' or 'add your review' link (http://prntscr.com/pj0bg6)

Expected result

  1. Auto scroll to review tab at bottom.

Actual result

  1. Did not scroll to review tab and encountered javascript error (http://prntscr.com/pj0d4g)

Suspect

  1. Code issue on line 51-72 of Magento_Review/js/process-reviews.js (http://prntscr.com/pj0djj)

@gaurav-473 gaurav-473 requested a review from DrewML as a code owner October 14, 2019 16:51
@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2019

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gaurav-473 gaurav-473 reopened this Oct 14, 2019
@ghost ghost unassigned VladimirZaets Oct 14, 2019
@ghost ghost assigned VladimirZaets Oct 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6113 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

Hello @gauravagarwal1001. Thanks for Your contribution. We can not fully reproduce the issue Your PR is going to fix. There is no need to duplicate the whole issue information in order to show You what exactly we are not able to reproduce. The difference is only in Actual Results. So Your's one looks like this:

Actual Result
Did not scroll to review tab and encountered javascript error (http://prntscr.com/pj0d4g)

while what we've got is somewhat different and would look like this:

Actual Result
Did not scroll to review tab when clicking on "Reviews" link but do scroll to that tab when clicking on "Add Your Review" link. No JavaScript errors in console are present, ether for "Reviews" or for "Add Your Review".

What do You think on it?

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 18, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2019
@magento-engcom-team magento-engcom-team merged commit 0e02b40 into magento:2.3-develop Oct 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 23, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this pull request Dec 5, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 5, 2019
@VladimirZaets
Copy link
Contributor

Covered in the scope of #25915

@adexandros
Copy link

This happens because there is a second script ui-modules/tabs.js that is loading after the first mage/tabs.js; so that when $('.product.data.items').tabs('activate', index); is invoked (webroot/vendor/magento/module-review/view/frontend/web/js/process-reviews.js on line 62) is referencing that second script and not the first one;
This seems to be requested by the page builder module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants