Skip to content

Fixed #24840 Drop down icon invisible for a moment if not select value and click on Load Template #25022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fixed #24840 Drop down icon invisible for a moment if not select value and click on Load Template #25022

merged 1 commit into from
Oct 18, 2019

Conversation

gaurav-473
Copy link
Contributor

@gaurav-473 gaurav-473 commented Oct 13, 2019 •
edited by sdzhepa
Loading

Fixed #24840

Preconditions (*)

M 2.3

Steps to reproduce (*)

  1. admin - email template - add new template
  2. without select template click on Load Template

Expected result (*)

drop down icon should be visible when click on Load Template

Actual result (*)

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2019

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@gaurav-473
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001, here is your new Magento instance.
Admin access: https://pr-25022.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch self-assigned this Oct 13, 2019
@dmytro-ch dmytro-ch self-requested a review October 13, 2019 11:51
dmytro-ch
dmytro-ch requested changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gauravagarwal1001,
unfortunately, the current solution is rather a workaround and it does not seem to be solving the real issue.
The bug is related to the particular case for the specific form. I think it should not be fixed globally and especially using the force state for CSS rule.

Thank you!

@gaurav-473
Copy link
Contributor Author

Hi @gauravagarwal1001,
unfortunately, the current solution is rather a workaround and it does not seem to be solving the real issue.
The bug is related to the particular case for the specific form. I think it should not be fixed globally and especially using the force state for CSS rule.

Thank you!

Hi @dmytro-ch
This issue will occurred with every dropdown field in every form whenever dropdown field is required in form because on click mage-error will set background-image none that's why I made dropdown background properties important.

@gaurav-473 gaurav-473 closed this Oct 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gaurav-473 gaurav-473 reopened this Oct 14, 2019
@ghost ghost unassigned dmytro-ch Oct 14, 2019
@gaurav-473 gaurav-473 requested a review from dmytro-ch October 14, 2019 18:08
@dmytro-ch dmytro-ch self-assigned this Oct 14, 2019
@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6114 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 17, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 17, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 18, 2019
@VladimirZaets
ENGCOM-6114: Fixed #24840 Drop down icon invisible for a moment if no…
6e7189c 
…t select value and click on Load Template #25022
@magento-engcom-team magento-engcom-team merged commit a52a0e5 into magento:2.3-develop Oct 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
@sivaschenko sivaschenko mentioned this pull request Nov 17, 2019
Closed
@drpayyne
Copy link
Contributor

Will be reverting this PR according to: #24840 (comment)

@drpayyne drpayyne mentioned this pull request Nov 18, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Community Insider: Cedcommerce community-insider-contribution Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.

Drop down icon invisible for a moment if not select value and click on Load Template
6 participants
@gaurav-473 @magento-engcom-team @engcom-Alfa @drpayyne @dmytro-ch @engcom-Golf