Skip to content

Update AbstractForm.php #24853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2019
Merged

Update AbstractForm.php #24853

merged 3 commits into from
Oct 8, 2019

Conversation

Vildulv
Copy link
Member

@Vildulv Vildulv commented Oct 4, 2019

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Vildulv Vildulv requested a review from YevSent as a code owner October 4, 2019 09:03
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2019

Hi @Vildulv. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Vildulv Vildulv closed this Oct 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2019

Hi @Vildulv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Vildulv Vildulv reopened this Oct 4, 2019
@swnsma swnsma self-assigned this Oct 4, 2019
@swnsma swnsma self-requested a review October 4, 2019 09:15
@swnsma swnsma added the Cleanup label Oct 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5997 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@Vildulv thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Oct 4, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

@swnsma swnsma self-requested a review October 4, 2019 10:06
swnsma
swnsma requested changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vildulv,

Thank you for your contribution!
According to Magento Refactoring Policy we need to refactor all failed static tests in files where changes was done.

Please, fix failed static tests.

@Vildulv Vildulv requested a review from swnsma October 4, 2019 13:21
@Vildulv
Copy link
Member Author

Vildulv commented Oct 4, 2019

Hi @Vildulv,

Thank you for your contribution!
According to Magento Refactoring Policy we need to refactor all failed static tests in files where changes was done.

Please, fix failed static tests.

Static tests is fixed.

@ghost ghost assigned sidolov Oct 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5997 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Vildulv Vildulv added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 4, 2019
@sidolov sidolov added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Oct 4, 2019
@Vildulv Vildulv requested a review from abukatar October 7, 2019 07:45
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5997 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Oct 8, 2019
@sidolov
ENGCOM-5997: Update AbstractForm.php #24853
f494e1c
@magento-engcom-team magento-engcom-team merged commit 2b9a7ca into magento:2.3-develop Oct 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @Vildulv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swnsma swnsma swnsma approved these changes

@sidolov sidolov sidolov approved these changes

@YevSent YevSent Awaiting requested review from YevSent

@abukatar abukatar Awaiting requested review from abukatar

Assignees

@swnsma swnsma

@sidolov sidolov

@engcom-Alfa engcom-Alfa

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Data Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Vildulv @magento-engcom-team @engcom-Alfa @swnsma @sidolov