Skip to content

Resolved Issue #24740 #24761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Sep 27, 2019

Description

Fixed Issue 24740

Extra margin for select fields caused the UI issue

Fixed Issues (if relevant)

  1. Change text and check box not in same aligned #24740: Change text and check box not in same aligned

Manual testing scenarios (*)

  1. Admin -> Catalog -> Products
  2. Select any product and from Action drop-down choose Update Attributes
  3. Review the Update Attributes page
  4. Checkboxes and its label will now be aligned as per fix

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@drpayyne
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne, here is your new Magento instance.
Admin access: https://pr-24761.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned sidolov Sep 27, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5968 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Karlasa Karlasa removed their request for review September 28, 2019 16:01
@engcom-Delta engcom-Delta self-assigned this Sep 30, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team merged commit be1194b into magento:2.3-develop Oct 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Partner: EY partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change text and check box not in same aligned
5 participants