Skip to content

#24581 Added unique key on eav_attribute_label table #24682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2019
Merged

#24581 Added unique key on eav_attribute_label table #24682

merged 3 commits into from
Oct 3, 2019

Conversation

KaushikChavda
Copy link
Contributor

@KaushikChavda KaushikChavda commented Sep 21, 2019 •
edited by ihor-sviziev
Loading

Description (*)

Fixed Issues (if relevant)

  1. Fixes MIssing unique key on eav_attribute_label table #24581: Missing unique key on eav_attribute_label table

Manual testing scenarios (*)

  1. Installed fresh magento2.3-develop and the unique key was missing
  2. After added the unique key to table reinstall Magento and its fixed.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 21, 2019

Hi @KaushikChavda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

VladimirZaets
VladimirZaets requested changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KaushikChavda, please, sign CLA, otherwise, we can't process your pull request

@ghost ghost assigned VladimirZaets Sep 23, 2019
@KaushikChavda
Copy link
Contributor Author

Hi @KaushikChavda, please, sign CLA, otherwise, we can't process your pull request

I've signed already.

@KaushikChavda
Copy link
Contributor Author

Hi @KaushikChavda, please, sign CLA, otherwise, we can't process your pull request

Hello @VladimirZaets could you please review now, I've sign the CLA.

@KaushikChavda
Copy link
Contributor Author

@VladimirZaets VladimirZaets & @akaplya

Please let me know what things are pending as all checks are Success.

Thanks

@ghost ghost assigned sidolov Sep 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5977 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Oct 2, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf engcom-Golf self-assigned this Oct 2, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 2, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Oct 3, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 3, 2019
@sidolov
ENGCOM-5977: #24581 Added unique key on eav_attribute_label table #24682
8e09f0c
@magento-engcom-team magento-engcom-team merged commit f5638be into magento:2.3-develop Oct 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @KaushikChavda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 3, 2019
@KaushikChavda KaushikChavda deleted the issue/24581 branch December 9, 2019 12:27
@ihor-sviziev
Copy link
Contributor

FYI changes from this PR were reverted in f3d3bce

@ihor-sviziev ihor-sviziev linked an issue Sep 28, 2020 that may be closed by this pull request
MIssing unique key on eav_attribute_label table #24581
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Eav Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.

MIssing unique key on eav_attribute_label table
8 participants
@KaushikChavda @magento-cicd2 @magento-engcom-team @engcom-Delta @ihor-sviziev @VladimirZaets @sidolov @engcom-Golf