Skip to content

Fix #7200 - Configurable Products dropdown not showing pricing #24255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Aug 23, 2019

Description (*)

Fix for #7200

Fixed Issues (if relevant)

  1. Configurable Products dropdown not showing pricing #7200: Configurable Products dropdown not showing pricing

Manual testing scenarios (*)

  1. Create a configurable product with two attributes and that the second attribute (second in the list, never the first one - it's essential for reproduction) has pricing differences.
  2. Go to the Frontend and watch the second attribute dropdown.
  3. It should contain price diff based on option selected at first select.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-requested a review August 25, 2019 11:00
@dmytro-ch dmytro-ch self-assigned this Aug 25, 2019
@dmytro-ch dmytro-ch added Award: bug fix Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5693 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

fter

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2019

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 4, 2019
@Bartlomiejsz Bartlomiejsz mentioned this pull request Dec 8, 2019
4 tasks
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_7200_configurable_products_dropdown_prices branch January 27, 2020 23:45
@Bartlomiejsz
Copy link
Contributor Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Bartlomiejsz. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Bartlomiejsz, here is your Magento instance.
Admin access: https://i-24255-2-4-develop.instances.magento-community.engineering/admin_e2d4
Login: 5378a2c3 Password: 35c6fece1ea6
Instance will be terminated in up to 3 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants