Skip to content

Correct array type hints in Visibility model #23532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Correct array type hints in Visibility model #23532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b40107
Correct array type hints
pmclain Jul 2, 2019
fd7ebc2
magento/magento2#23532 Fix-static-tests
engcom-Foxtrot Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/code/Magento/Catalog/Model/Product/Visibility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function __construct(
/**
* Retrieve visible in catalog ids array
*
* @return string[]
* @return int[]
*/
public function getVisibleInCatalogIds()
{
Expand All @@ -65,7 +65,7 @@ public function getVisibleInCatalogIds()
/**
* Retrieve visible in search ids array
*
* @return string[]
* @return int[]
*/
public function getVisibleInSearchIds()
{
Expand All @@ -75,7 +75,7 @@ public function getVisibleInSearchIds()
/**
* Retrieve visible in site ids array
*
* @return string[]
* @return int[]
*/
public function getVisibleInSiteIds()
{
Expand All @@ -86,6 +86,7 @@ public function getVisibleInSiteIds()
* Retrieve option array
*
* @return array
* phpcs:disable Magento2.Functions.StaticFunction
*/
public static function getOptionArray()
{
Expand Down Expand Up @@ -134,6 +135,7 @@ public static function getOptionText($optionId)
$options = self::getOptionArray();
return isset($options[$optionId]) ? $options[$optionId] : null;
}
//phpcs:enable Magento2.Functions.StaticFunction

/**
* Retrieve flat column definition
Expand Down Expand Up @@ -251,7 +253,7 @@ public function addValueSortToCollection($collection, $dir = 'asc')
}

/**
* {@inheritdoc}
* @inheritdoc
*/
public function toOptionArray()
{
Expand Down