-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #12256 #13263 - add Serbian Latin language and change language lists to show script #22293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12256 #13263 - add Serbian Latin language and change language lists to show script #22293
Conversation
Hi @Bartlomiejsz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @Bartlomiejsz, I looked into your pull request but noticed it requires some time to comprehend logic :) Will review this week. |
@orlangur great, thank you :) |
Hi @orlangur, any news regarding this one? |
@magento run all tests |
Hi @Bartlomiejsz , could you please fix static tests and cover introduced changes with automated tests? Thank you! |
…ge language lists to show script
f29819a
to
29411fe
Compare
Hi @sidolov, done, please review :) |
Hi @sidolov, thank you for the review.
|
✔️ QA Passed |
…e language lists to show script #22293
Hi @Bartlomiejsz, thank you for your contribution! |
Description (*)
This PR adds Serbian Latin language and allows to distinguish which locale is Latin and which is Cyrillic.
Second change is to display script in locale name, so user can select correct language he wants. Before change both sr_Cyrl_RS and sr_Latn_RS would be displayed as Serbian (Serbia). Now those are Serbian (Cyrillic, Serbia) and Serbian (Latin, Serbia).
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)