Skip to content

Fix #12256 #13263 - add Serbian Latin language and change language lists to show script #22293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Apr 11, 2019

Description (*)

This PR adds Serbian Latin language and allows to distinguish which locale is Latin and which is Cyrillic.
Second change is to display script in locale name, so user can select correct language he wants. Before change both sr_Cyrl_RS and sr_Latn_RS would be displayed as Serbian (Serbia). Now those are Serbian (Cyrillic, Serbia) and Serbian (Latin, Serbia).

Fixed Issues (if relevant)

  1. Option to select durring instalation Serbian Latin or Serbian Cyrilic #12256: Option to select durring instalation Serbian Latin or Serbian Cyrilic
  2. In the magenta (all versions) there is no option to choose Serbian-Latin #13263: In the magenta (all versions) there is no option to choose Serbian-Latin

Manual testing scenarios (*)

  1. Go to MBO
  2. Go to Stores -> Configuration -> General -> General -> Locale Options -> Locale
  3. See both Serbian (Cyrillic, Serbia) and Serbian (Latin, Serbia) locales

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

Hi @Bartlomiejsz, I looked into your pull request but noticed it requires some time to comprehend logic :) Will review this week.

@orlangur orlangur self-assigned this Apr 15, 2019
@Bartlomiejsz
Copy link
Contributor Author

@orlangur great, thank you :)

@Bartlomiejsz
Copy link
Contributor Author

Hi @orlangur, any news regarding this one?

@sidolov
Copy link
Contributor

sidolov commented Sep 26, 2019

@magento run all tests

@sidolov
Copy link
Contributor

sidolov commented Sep 26, 2019

Hi @Bartlomiejsz , could you please fix static tests and cover introduced changes with automated tests? Thank you!

@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_12256_13263_add_serbian_latin branch from f29819a to 29411fe Compare September 29, 2019 21:09
@Bartlomiejsz
Copy link
Contributor Author

Hi @sidolov, done, please review :)

@ghost ghost assigned sidolov Sep 30, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5972 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 3, 2019
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_12256_13263_add_serbian_latin branch September 19, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants