Skip to content

[Backport] Add argument to show filter text in URL rewrite grid after click on back button #22069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#21834

Description (*)

Changes are related to URL grid issue (i.e. https://github.com/magento/magento2/issues/21805)
Argument i.e. "save_parameters_in_session" is not available in below xml file.
XML file: adminhtml_logging_block.xml

Fixed Issues (if relevant)

  1. Filter in url rewrites table in backend isn't being remembered #21805: Filter in url rewrites table in backend isn't being remembered

Manual testing scenarios (*)

In Magento backend, go to Marketing > URL Rewrites
Put a filter in one of the columns (like in the Request Path column) and apply it
Click on one of the filtered results
Click on the Back button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned rogyar Mar 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4621 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 4, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants