Fix #21725 - Render price on category list with correct precision for current locale #21829

Bartlomiejsz · 2019-03-18T23:16:26Z

Description (*)

This PR changes price rendering on category view to include correct precision for current locale and currency.

Fixed Issues (if relevant)

Fixes Price Precision wrong on product listing pages #21725

Manual testing scenarios (*)

Magento 2.3.0
Default locale set should be for Oman (ar_OM it's not by default available in Magento, need to be added in \Magento\Framework\Locale\Config but didn't check all locales to verify where it also occurs), Oman Rial (OMR) selected as currency
Visit product listing page - see that the products have prices with precision 3.
Visit product details page - see that the products have prices with precision 3.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2019-03-18T23:16:29Z

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-engcom-team · 2019-03-20T07:37:39Z

Hi @aleron75, thank you for the review.
ENGCOM-4538 has been created to process this Pull Request

aleron75 · 2019-03-20T07:37:41Z

Hello @Bartlomiejsz thanks for your contribution.

Once merged, don't forget you can easily port this PR (if needed) to other branches with the Porting Tool, read more here.

VasylShvorak · 2019-03-22T11:21:59Z

Hi @Bartlomiejsz during testing, I found more places when price is rendered with incorrect precision. And subtotal price on cart page is rendered with two comma separators(issue is present on 2.3-develop and not caused by PR). So price inconsistency is still present after your fix.

Manual testing scenario:

Create simple product with Price=123,46
Set Stores->Configuration->General->General->Locale Options->Arabic (Saudi Arabia)
Go Stores->Configuration->General->Currency Setup
Set Base Currency=Omani Rial, Default Display Currency=Omani Rial,Allowed Currencies=Omani Rial
Check cart page, minicart and checkout page
❌ Price precision is not rendered correctly

@sivaschenko Could you check if testing scenario is valid for PR changes?

sivaschenko · 2019-03-22T12:25:28Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-03-22T12:25:33Z

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-03-22T12:26:16Z

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-21829.instances.magento-community.engineering/admin
Login: admin Password: 123123q

sivaschenko · 2019-03-22T14:10:35Z

@VasylShvorak the scenario looks valid to me. I think the sum is displayed correctly during checkout (looks like two different commas used)

@Bartlomiejsz would you be able to fix the price precision in the mini cart, shopping cart page and emails for consistency?

Bartlomiejsz · 2019-03-22T19:21:30Z

@sivaschenko yes, I will work on that

Bartlomiejsz · 2019-03-26T22:11:06Z

@VasylShvorak @sivaschenko could you test this one again with newest changes?

sivaschenko

Thanks for updates @Bartlomiejsz A couple of minor changes required for backward compatibility: please see my review comments

app/code/Magento/Sales/Model/Order.php

lib/internal/Magento/Framework/Pricing/Render/Amount.php

engcom-Foxtrot · 2020-11-19T13:47:12Z

@magento run all tests

engcom-Foxtrot · 2020-11-27T14:44:56Z

@magento run all tests

engcom-Foxtrot · 2020-11-30T11:27:13Z

@magento run all tests

aleron75 · 2020-12-03T07:05:57Z

app/code/Magento/Catalog/Model/Product/Type/Price.php

     * @since 102.0.6
     */
    public function getFormattedTierPrice($qty, $product)
    {
        $price = $product->getTierPrice($qty);
        if (is_array($price)) {
            foreach (array_keys($price) as $index) {
-                $price[$index]['formatted_price'] = $this->priceCurrency->convertAndFormat(
+                $price[$index]['formatted_price'] = $this->amount->convertAndFormatCurrency(
                    $price[$index]['website_price']
                );
            }
        } else {


As done before to improve readability, the return early pattern can also be applied here, returning $price at the end of the loop and avoiding the else statement.

ihor-sviziev · 2020-12-16T10:25:05Z

Moving to on hold as this PR waiting for opening 2.5 develop branch

ihor-sviziev · 2021-01-12T07:06:46Z

@Bartlomiejsz Branch 2.5-develop was already created. Could you re-target this PR to the 2.5-develop branch?

Bartlomiejsz · 2021-01-12T07:18:02Z

Yes, @ihor-sviziev I'll try to work on this PR in upcoming days

m2-assistant · 2021-01-15T21:13:26Z

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Bartlomiejsz · 2021-01-15T21:15:04Z

@sivaschenko didn't really try to close this PR, it got automatically closed when I force pushed changes re-created on 2.5-develop branch, I will create new one for it

ihor-sviziev · 2021-01-16T10:39:16Z

@Bartlomiejsz seems like you force pushed branch with no changes

magento-engcom-team added Component: Pricing Release Line: 2.3 labels Mar 18, 2019

aleron75 approved these changes Mar 20, 2019

View reviewed changes

ghost assigned aleron75 Mar 20, 2019

ghost added the Progress: ready for testing label Mar 20, 2019

VasylShvorak self-assigned this Mar 22, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 22, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Mar 22, 2019

Bartlomiejsz requested a review from aleron75 March 24, 2019 22:16

sivaschenko requested changes Apr 1, 2019

View reviewed changes

app/code/Magento/Sales/Model/Order.php Outdated Show resolved Hide resolved

lib/internal/Magento/Framework/Pricing/Render/Amount.php Outdated Show resolved Hide resolved

ghost assigned sivaschenko Apr 1, 2019

Bartlomiejsz requested a review from sivaschenko April 1, 2019 14:18

sivaschenko requested changes Apr 4, 2019

View reviewed changes

lib/internal/Magento/Framework/Pricing/Render/Amount.php Outdated Show resolved Hide resolved

sivaschenko approved these changes Apr 4, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 4, 2019

magento-engcom-team added Component: Checkout Component: Locale labels Apr 4, 2019

sivaschenko added this to the 2.5 milestone Nov 2, 2020

engcom-Foxtrot self-assigned this Nov 19, 2020

aleron75 reviewed Dec 3, 2020

View reviewed changes

m2-community-project bot added Progress: review and removed Progress: needs update labels Dec 3, 2020

aleron75 added the Award: MFTF test coverage label Dec 3, 2020

ihor-sviziev added the Progress: on hold label Dec 16, 2020

m2-community-project bot removed the Progress: review label Dec 16, 2020

ihor-sviziev added the Progress: review label Jan 12, 2021

m2-community-project bot removed the Progress: on hold label Jan 12, 2021

ihor-sviziev added the Progress: needs update label Jan 12, 2021

m2-community-project bot removed the Progress: review label Jan 12, 2021

Bartlomiejsz closed this Jan 15, 2021

Bartlomiejsz force-pushed the feature/fix_21725_price_precision_wrong branch from 5f1858e to 1e846a4 Compare January 15, 2021 21:13

m2-community-project bot removed the Progress: needs update label Jan 15, 2021

Bartlomiejsz mentioned this pull request Jan 15, 2021

Fix #21725 - Render price on category list with correct precision for current locale #31661

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #21725 - Render price on category list with correct precision for current locale #21829

Fix #21725 - Render price on category list with correct precision for current locale #21829

Bartlomiejsz commented Mar 18, 2019 •

edited

Loading

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 20, 2019

aleron75 commented Mar 20, 2019

VasylShvorak commented Mar 22, 2019

sivaschenko commented Mar 22, 2019

magento-engcom-team commented Mar 22, 2019

magento-engcom-team commented Mar 22, 2019

sivaschenko commented Mar 22, 2019 •

edited

Loading

Bartlomiejsz commented Mar 22, 2019

Bartlomiejsz commented Mar 26, 2019

sivaschenko left a comment

engcom-Foxtrot commented Nov 19, 2020

engcom-Foxtrot commented Nov 27, 2020

engcom-Foxtrot commented Nov 30, 2020

aleron75 Dec 3, 2020

ihor-sviziev commented Dec 16, 2020

ihor-sviziev commented Jan 12, 2021

Bartlomiejsz commented Jan 12, 2021

m2-assistant bot commented Jan 15, 2021

Bartlomiejsz commented Jan 15, 2021

ihor-sviziev commented Jan 16, 2021

Fix #21725 - Render price on category list with correct precision for current locale #21829

Fix #21725 - Render price on category list with correct precision for current locale #21829

Conversation

Bartlomiejsz commented Mar 18, 2019 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 20, 2019

aleron75 commented Mar 20, 2019

VasylShvorak commented Mar 22, 2019

sivaschenko commented Mar 22, 2019

magento-engcom-team commented Mar 22, 2019

magento-engcom-team commented Mar 22, 2019

sivaschenko commented Mar 22, 2019 • edited Loading

Bartlomiejsz commented Mar 22, 2019

Bartlomiejsz commented Mar 26, 2019

sivaschenko left a comment

Choose a reason for hiding this comment

engcom-Foxtrot commented Nov 19, 2020

engcom-Foxtrot commented Nov 27, 2020

engcom-Foxtrot commented Nov 30, 2020

aleron75 Dec 3, 2020

Choose a reason for hiding this comment

ihor-sviziev commented Dec 16, 2020

ihor-sviziev commented Jan 12, 2021

Bartlomiejsz commented Jan 12, 2021

m2-assistant bot commented Jan 15, 2021

Bartlomiejsz commented Jan 15, 2021

ihor-sviziev commented Jan 16, 2021

Bartlomiejsz commented Mar 18, 2019 •

edited

Loading

sivaschenko commented Mar 22, 2019 •

edited

Loading