[Backport] Fix #21692 #21752 - logic in constructor of address validator and Locale Resolver check

[Bartlomiejsz]

Original Pull Request

#21693

Description (*)

This fixes issue #21692 - error is described there. This is backport for Magento 2.2.

Fixed Issues (if relevant)

1. Incorrect constructor of Magento\Sales\Model\Order\Address\Validator #21692: Incorrect constructor of Magento\Sales\Model\Order\Address\Validator

Manual testing scenarios (*)

1. Add custom module with Cli Command and inject Magento\Sales\Model\Order\Address\Validator into its constructor
2. Run Magento installation from Cli
3. Verify if installation is finished with success

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4484 has been created to process this Pull Request

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4484 has been created to process this Pull Request

[soleksii]

Hi @Bartlomiejsz !

I've checked PR and it looks like changes does not fix the issue #21752.

Manual testing scenario:

1. Add custom module with Cli Command and inject Magento\Sales\Model\Order\Address\Validator into its constructor;
2. Try to install Magento from scratch using Cli;
3. See following error:

[Bartlomiejsz]

Hi @stoleksiy!
It seems like on 2.2-develop there is another error connected with this. I will work on that.

[Bartlomiejsz]

Hi @stoleksiy!
Could you please confirm that you have this error with my changes? I checked it three times, and installation on 2.2-develop with such custom module fails with exactly same error that you mentioned, but on branch for this ticket installation for same steps is finished successfully.
If it is not working for you, could you attach here your cli command code?

[soleksii]

Hi @Bartlomiejsz! I re-checked this PR and everything is fine. Thanks!

[soleksii]

✔️ QA Passed

Result:

[ghost]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.