fixed cutting off long oauth callback urls for oauth clients like google apps script (Google Drive) #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle drive apps script by increasing size of callback_url, rejected_callback_url columns from 255 to 512 chars
|
Internal ticket: MAGETWO-46678 |
okorshenko
pushed a commit
that referenced
this pull request
Jan 4, 2016
magento-team
pushed a commit
that referenced
this pull request
Feb 5, 2016
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 27, 2018
Fixed issues: - MAGETWO-87856 Generate SCD in Production mode [2.2.x]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed cutting off long oauth callback urls for oauth clients like Google Drive Apps Script by increasing size of callback_url, rejected_callback_url columns from 255 to 512 chars
Google Drives Apps Script have very long oauth URLs.
Example:
https://script.google.com/macros/d/MR7xx5QeHK_nwZLsUd8pxVZXvWRuAoVU2/usercallback?state=ADEpC8zf967naK-fzUxtnUVDyckTiet7SC7ci3sj-qztyiv0X8C91iTemZedlAAQ3sAm6jxCq00KNPwPJts8cOABWaddof_xskq6rUu25EAD1d5C4BwWOEOK4Ud9qGl3b7ofAe-Rs-46M_EJjTifs5i3b--ZDz-FMpz1Kk4m6jxCq00KNPwPJts&oauth_token=0896ce575a666a8113d382bb849bd0f0&oauth_verifier=1f3719ba1d2d5ae4a739be1bf79644f4
Magento saves it in callback_url column and cuts 16 chars (from example above).
That is why it's not possible to write Addons for Goolgle Sheets/Documents.
Please increase the size of callback_url and rejected_callback_url columns.
Links: