Skip to content

Adjust table for grouped products #20808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Adjust table for grouped products #20808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc6bc8b
Adjust table for grouped products
Jan 30, 2019
9ef4c2d
ENGCOM-4061: MTF test fix.
p-bystritsky Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
</thead>

<?php if ($_hasAssociatedProducts): ?>
<?php foreach ($_associatedProducts as $_item): ?>
<tbody>
<?php foreach ($_associatedProducts as $_item): ?>
<tr>
<td data-th="<?= $block->escapeHtml(__('Product Name')) ?>" class="col item">
<strong class="product-item-name"><?= $block->escapeHtml($_item->getName()) ?></strong>
Expand Down Expand Up @@ -80,8 +80,8 @@
</td>
</tr>
<?php endif; ?>
</tbody>
<?php endforeach; ?>
</tbody>
<?php else: ?>
<tbody>
<tr>
Expand Down
5 changes: 3 additions & 2 deletions dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Block/Catalog/Product/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ class View extends ParentView
*
* @var string
*/
protected $formatTierPrice = "//tbody[%row-number%]//ul[contains(@class,'tier')]//*[@class='item'][%line-number%]";
protected $formatTierPrice =
"//tr[@class='row-tier-price'][%row-number%]//ul[contains(@class,'tier')]//*[@class='item'][%line-number%]";

/**
* This member holds the class name of the special price block.
*
* @var string
*/
protected $formatSpecialPrice = '//tbody[%row-number%]//*[contains(@class,"price-box")]';
protected $formatSpecialPrice = '//tbody//tr[%row-number%]//*[contains(@class,"price-box")]';

/**
* Get grouped product block
Expand Down