Skip to content

My-account-page-title-extra-space-on-mobile #20725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. My account page title extra space on mobile (when not display error or success messages) #20723: My account page title extra space on mobile

Manual testing scenarios (*)

  1. My Account page title in mobile view
  2. Magento 2.3.x

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 28, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20725.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 28, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-20725-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 28, 2019

Hello @amol2jcommerce

During testing, I faced a new issue.
Could you please have a look and fix it?

  • Problem: My Account page title loads with extra space but after 3-4 sec jumps to the new position

Manual testing scenario:

  1. Go to Storefront on mobile (used real iPhone 5 device)
  2. Create new Customer and go to My Account page

Actual Result:

  • Title is load with old space
  • After several second Title is changing position

See the attached video for more details(using physical device resultat the same)
pr_20725_gif

Thank you for contribution and collaboration!

@amol2jcommerce
Copy link
Contributor Author

Hi @sdzhepa thanks for review.
Please review once I sorted above mention issues.

@amol2jcommerce
Copy link
Contributor Author

Hi @sdzhepa please review.

@sdzhepa sdzhepa self-requested a review January 29, 2019 11:52
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 29, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20725.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-4028 has been created to process this Pull Request

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 29, 2019

Hello @amol2jcommerce

I have reviewed this PR and put into a delivery queue.

Thank you for quick feedback and contribution!

@amol2jcommerce
Copy link
Contributor Author

Thanks @sdzhepa

@ghost
Copy link

ghost commented Feb 1, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants