Skip to content

[Backport] 2.2 develop pr port 19136 #20641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Added option to exclude discount for minimum order amount calculation #19136
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@milindsingh
Copy link
Member

Duplicate #18524

@ghost
Copy link

ghost commented Jan 27, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@amol2jcommerce
Copy link
Contributor Author

amol2jcommerce commented Jan 27, 2019

@milindsingh
since backport PR is not using original commit , do not close my backport.

@DanielRuf
Copy link
Contributor

The other is from the original commit author.

@DanielRuf DanielRuf closed this Jan 27, 2019
@magento magento deleted a comment Jan 27, 2019
@amol2jcommerce amol2jcommerce deleted the 2.2-develop-PR-port-19136 branch January 28, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants