magento/magento2#12817: [Forwardport] Coupon code with canceled order.

[p-bystritsky]

Forwardport for https://github.com/magento-engcom/magento2ce/pull/1095

Description

The number of coupon code uses is decreased if an order, that previously used this coupon code, is canceled.

Fixed Issues (if relevant)

1. Coupon code with canceled order #12817: Coupon code with canceled order

Manual testing scenarios

1. Create a Cart Price Rule with Specific Coupon. Set Uses per Coupon to 1.
2. Create Order (1st Order).
3. Apply the Coupon to 1st Order.
4. Place the 1st Order.
5. Create Order (2nd Order).
6. Apply the Coupon to 2nd Order.
7. Message "Coupon code is not valid" appears.
8. Cancel 1st Order.
9. Apply the Coupon to 2nd Order.
10. Message "Your coupon was successfully applied." appears.
11. Create a Cart Price Rule with Specific Coupon. Set Uses per Customer to 1.
12. Repeat steps 2-10 with this Coupon (note than orders must be placed by logged customer).

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[PascalBrouwers]

@slavvka Can you just approve this? Because it comes from 2.2.4 branch.

[davidverholen]

closed and reopened to trigger new checks

[p-bystritsky]

@davidverholen our suggestions committed.

[magento-engcom-team]

Hi @davidverholen, thank you for the review.
ENGCOM-5171 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[ghost]

@ysapiga unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[p-bystritsky]

@p-bystritsky why did you move it back to changes requested?

@davidverholen we had some non-public issues, but now it seems like they are fixed.

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.