Skip to content

[Backport] Issue fixed #19985 Send email confirmation popup close button area ov… #20541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

irajneeshgupta
Copy link
Member

Original Pull Request

#19986
Issue fixed #19985 Send email confirmation popup close button area overlapping

Description (*)

Send email confirmation popup close button area overlapping

Fixed Issues (if relevant)

#19985

Manual testing scenarios (*)

Step 1: Login to admin panel
Step 2: Go to sales > order grid
Step 3: Edit any order
Step 4: Please click on send email from above links (Now you ref from actual result screenshot)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…area overlapping to content

Issue fixed magento#19985 Send email confirmation popup close button area overlapping to content
…area overlapping

Issue fixed magento#19985 Send email confirmation popup close button area overlapping
@magento-engcom-team
Copy link
Contributor

Hi @irajneeshgupta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3970 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 26, 2019

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 2e4d7e1 into magento:2.2-develop Jan 26, 2019
magento-engcom-team pushed a commit that referenced this pull request Jan 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @irajneeshgupta. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants