Skip to content

[Backport] Add useful debug info for which website has not been found #20522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2019
Merged

[Backport] Add useful debug info for which website has not been found #20522

merged 3 commits into from
Jan 26, 2019

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#19709

Description (*)

After running Magento setup, with custom modules, you may have created settings for store and websites that do not exist yet.

This creates entries in core_config_data.

When running bin/magento to complete the settings and data migration, Magento will crash with the error message:

No such entity.

This code adds something useful to the user, informing them it is because the website Id requested does not exist.

Manual testing scenarios (*)

  1. Install Magento 2.3.0
  2. Have any module insert data into core_config_data, with website scope values
  3. Run bin/magento
  4. It will crash with above message

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3945 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 3e9ba6e into magento:2.2-develop Jan 26, 2019
@ghost
Copy link

ghost commented Jan 26, 2019

Hi @mageprince, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants