Skip to content

fixes-for-schedule-in-admin:: Schedule Update From (Schedule Design U… #20431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2019
Merged

fixes-for-schedule-in-admin:: Schedule Update From (Schedule Design U… #20431

merged 2 commits into from
Aug 9, 2019

Conversation

nadim2jcommerce
Copy link
Contributor

@nadim2jcommerce nadim2jcommerce commented Jan 21, 2019 •
edited by sdzhepa
Loading

Description (*)

In 2.3.0 version Schedule Update From (Schedule Design Update) not saving When switch store view from admin

Fixed Issues (if relevant)

1.#20377: Schedule Update From (Schedule Design Update) not saving When switch store view from admin

Manual testing scenarios (*)

  1. Go to admin panel
  2. Admin=>Catalog=>Categories=>Navigate any category=>Schedule Design Update
  3. Switch store to "default store view"
  4. Click on checkbox (Checked) and save.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@nadim2jcommerce
fixes-for-schedule-in-admin:: Schedule Update From (Schedule Design U…
6eb9717 
…pdate) not saving When switch store view from admin
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @nadim2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Stepa4man
Stepa4man approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nadim2jcommerce, Thanks for your contribution.

@ghost ghost assigned Stepa4man Jul 16, 2019
@engcom-Delta engcom-Delta self-assigned this Jul 17, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 17, 2019
sivaschenko
sivaschenko requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nadim2jcommerce can you please update your branch and resolve conflicts

@ghost ghost assigned sivaschenko Jul 24, 2019
@engcom-Foxtrot
Merge remote-tracking branch 'mainline/2.3-develop' into fixes-for-sc…
aa11360 
…hedule-in-admin

# Conflicts:
#	app/code/Magento/Catalog/view/adminhtml/ui_component/category_form.xml
@engcom-Foxtrot
Copy link
Contributor

@sivaschenko resolved.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@Stepa4man Stepa4man requested a review from sivaschenko July 28, 2019 14:35
@Stepa4man
Copy link
Contributor

@sivaschenko @engcom-Foxtrot resolved conflicts as I can see. Could you please merge?

@magento-engcom-team magento-engcom-team mentioned this pull request Aug 9, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit aa11360 into magento:2.3-develop Aug 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 9, 2019

Hi @nadim2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 9, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 9, 2019
@VladimirZaets
ENGCOM-5454: fixes-for-schedule-in-admin:: Schedule Update From (Sche…
5dd4c01 
…dule Design U… magento#20431
@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stepa4man Stepa4man Stepa4man approved these changes

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

Assignees

@sivaschenko sivaschenko

@Stepa4man Stepa4man

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: Catalog Partner: AYKO Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
8 participants
@nadim2jcommerce @magento-cicd2 @magento-engcom-team @engcom-Delta @engcom-Foxtrot @Stepa4man @sivaschenko @sidolov