Fix: #20379 Calendar icon not aligned inside the textbox in Add Design Change page

[irajneeshgupta]

Description (*)

Changed class admin__scope-old to form-inline.

Fixed Issues (if relevant)

1. calendar icon not aligned inside the textbox in Add Design Change page #20379: Issue title:calendar icon not aligned inside the textbox in Add Design Change page

Manual testing scenarios (*)

1. ...
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @irajneeshgupta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Hi @irajneeshgupta thanks for the pull request! According to the description the PR is targeted to fix a single calendar icon. I think that the fix should be much more specific to that icon.

Additionally, I don't understand what is the issue, the calendar icon looks completely fine in my opinion.

[hostep]

@sivaschenko: I believe this already got fixed in: #18593, we have this one as a patch on our shops and it fixes a bunch of incorrectly aligned calendar icons if I remember correctly.

[sivaschenko]

@hostep thanks for the tip, however, I believe that was a different issue. This PR is changing old calendar icon style (outside the input box) to new (inside the input box)

[hostep]

@sivaschenko: ah yes, you are correct, sorry, my bad!

[irajneeshgupta]

@sivaschenko
any updates on this PR.

[sivaschenko]

@irajneeshgupta please see the code review comments #20389 (review)

[sidolov]

@irajneeshgupta , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.