Skip to content

[Backport] Changes for Product-per-row-not-proper-on-listing-page #20327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Backport] Changes for Product-per-row-not-proper-on-listing-page #20327

wants to merge 1 commit into from

Conversation

GovindaSharma
Copy link
Contributor

Original Pull Request

#20168

Description (*)

Fixed Issues (if relevant)

  1. Product per row not proper on listing page  #20140: Product per row not proper on listing page
  2. ...

Manual testing scenarios (*)

  1. In any listing page of version 2.3 for all view
  2. No of product per row not proper

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3883 has been created to process this Pull Request

@sivaschenko sivaschenko self-assigned this Jan 18, 2019
@sivaschenko
Copy link
Member

Hi @GovindaSharma thanks for the backport, however, the issue cannot be reproduced on 2.2-develop. I am closing this pull request as not actual. Feel free to reopen if there are more details to reproduce the issue on 2.2-develop.

@ghost
Copy link

ghost commented Jan 18, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants