Skip to content

[Backport] Fix issue causing attribute not loading when using getList #20284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2019
Merged

[Backport] Fix issue causing attribute not loading when using getList #20284

merged 2 commits into from
Jan 27, 2019

Conversation

GovindaSharma
Copy link
Contributor

Original Pull Request

#19620

Description (*)

As specified in issue #17759, CustomerRepository::getList() is unexpectedly returning NULL, when CustomerRepository::get() is correctly returning the value. Specifying the attribute as billing_company instead of company removes the conflict.

Fixed Issues (if relevant)

  1. M2.2.5 : CustomerRepository::getList() does not load custom attribute if the name is "company" #17759: M2.2.5 : CustomerRepository::getList() does not load custom attribute if the name is "company"

Manual testing scenarios (*)

  1. Create/Install two custom varchar customer attributes, one with the code company.
  2. Log the data when loading with getbyId():
    $customerById = $customerRepository->getbyId(x);
  3. Log the data when loading with getList():
    $customerByList = $customerRepository->getList($searchCriteria->addFilter('x, y')->create());

Previously, under custom attributes, both attributes were loading correctly for getbyId(), but company would pull NULL when using getList()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

teganbold and others added 2 commits January 14, 2019 14:16
As specified in issue #17759, CustomerRepository::getList() is
unexpectedly returning NULL, when CustomerRepository::get() is correctly
returning the value. Specifying the attribute as billing_company instead
of company removes the conflict.
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3868 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 27, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants